Skip to content

Commit e8287ab

Browse files
committed
ref(ci): overlap devservices with webpack build in acceptance tests
Apply the same early-devservices pattern from the backend test change. Acceptance tests have several minutes of webpack/node build between checkout and setup-sentry, so devservices will be fully ready by the time the venv is set up — the entire ~90s of container startup becomes free.
1 parent 6f2aa2c commit e8287ab

1 file changed

Lines changed: 16 additions & 0 deletions

File tree

‎.github/workflows/acceptance.yml‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,11 @@ jobs:
6868
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
6969
name: Checkout sentry
7070

71+
- name: Start devservices early
72+
uses: ./.github/actions/setup-devservices
73+
with:
74+
mode: acceptance-ci
75+
7176
- name: Step configurations
7277
id: config
7378
run: |
@@ -98,13 +103,24 @@ jobs:
98103
id: setup
99104
with:
100105
mode: acceptance-ci
106+
skip-devservices: 'true'
107+
108+
- name: Wait for devservices
109+
run: |
110+
sentry init
111+
./.github/actions/setup-devservices/wait.sh
101112
102113
- name: Run acceptance tests (#${{ steps.setup.outputs.matrix-instance-number }} of ${{ steps.setup.outputs.matrix-instance-total }})
103114
run: make run-acceptance
104115

105116
- name: Inspect failure
106117
if: failure()
107118
run: |
119+
if [ -f /tmp/ds.log ]; then
120+
echo "--- devservices startup log ---"
121+
cat /tmp/ds.log
122+
fi
123+
108124
if command -v devservices; then
109125
devservices logs
110126
fi

0 commit comments

Comments
 (0)