Skip to content

Commit fd5acbc

Browse files
authored
deps(ui): Upgrade react testing library dependencies (#72137)
1 parent 3132d36 commit fd5acbc

File tree

4 files changed

+67
-132
lines changed

4 files changed

+67
-132
lines changed

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,9 +180,10 @@
180180
"@sentry/jest-environment": "6.0.0",
181181
"@sentry/profiling-node": "^8.0.0",
182182
"@styled/typescript-styled-plugin": "^1.0.1",
183+
"@testing-library/dom": "10.1.0",
183184
"@testing-library/jest-dom": "6.4.5",
184-
"@testing-library/react": "^14.2.1",
185-
"@testing-library/user-event": "^14.5.2",
185+
"@testing-library/react": "16.0.0",
186+
"@testing-library/user-event": "14.5.2",
186187
"@types/node": "^20.11.7",
187188
"babel-gettext-extractor": "^4.1.3",
188189
"babel-jest": "29.7.0",

static/app/components/sidebar/index.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ describe('Sidebar', function () {
256256
const {unmount} = renderSidebar({organization});
257257

258258
// This will start timer to mark as seen
259-
await userEvent.click(await screen.findByRole('link', {name: "What's new"}), {
259+
await userEvent.click(await screen.findByTestId('sidebar-broadcasts'), {
260260
delay: null,
261261
});
262262
expect(await screen.findByText("What's new in Sentry")).toBeInTheDocument();

static/app/components/sidebar/sidebarDropdown/switchOrganization.spec.tsx

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@ describe('SwitchOrganization', function () {
2121
expect(screen.getByRole('list')).toBeInTheDocument();
2222

2323
expect(screen.getByText('Organization 1')).toBeInTheDocument();
24-
expect(screen.getByRole('link', {name: 'org slug Organization 1'})).toHaveAttribute(
24+
expect(screen.getByRole('link', {name: 'OS Organization 1'})).toHaveAttribute(
2525
'href',
2626
'/organizations/org-slug/issues/'
2727
);
2828

2929
expect(screen.getByText('Organization 2')).toBeInTheDocument();
30-
expect(screen.getByRole('link', {name: 'org2 Organization 2'})).toHaveAttribute(
30+
expect(screen.getByRole('link', {name: 'O Organization 2'})).toHaveAttribute(
3131
'href',
3232
'/organizations/org2/issues/'
3333
);
@@ -57,11 +57,11 @@ describe('SwitchOrganization', function () {
5757

5858
expect(screen.getByRole('list')).toBeInTheDocument();
5959

60-
const org1Link = screen.getByRole('link', {name: 'org1 Organization 1'});
60+
const org1Link = screen.getByRole('link', {name: 'O Organization 1'});
6161
expect(org1Link).toBeInTheDocument();
6262
expect(org1Link).toHaveAttribute('href', '/organizations/org1/issues/');
6363

64-
const org2Link = screen.getByRole('link', {name: 'org2 Organization 2'});
64+
const org2Link = screen.getByRole('link', {name: 'O Organization 2'});
6565
expect(org2Link).toBeInTheDocument();
6666
expect(org2Link).toHaveAttribute(
6767
'href',
@@ -92,11 +92,11 @@ describe('SwitchOrganization', function () {
9292

9393
expect(screen.getByRole('list')).toBeInTheDocument();
9494

95-
const org1Link = screen.getByRole('link', {name: 'org1 Organization 1'});
95+
const org1Link = screen.getByRole('link', {name: 'O Organization 1'});
9696
expect(org1Link).toBeInTheDocument();
9797
expect(org1Link).toHaveAttribute('href', '/organizations/org1/issues/');
9898

99-
const org2Link = screen.getByRole('link', {name: 'org2 Organization 2'});
99+
const org2Link = screen.getByRole('link', {name: 'O Organization 2'});
100100
expect(org2Link).toBeInTheDocument();
101101
expect(org2Link).toHaveAttribute('href', '/organizations/org2/issues/');
102102
jest.useRealTimers();
@@ -128,7 +128,7 @@ describe('SwitchOrganization', function () {
128128

129129
expect(screen.getByRole('list')).toBeInTheDocument();
130130

131-
const org1Link = screen.getByRole('link', {name: 'org1 Organization 1'});
131+
const org1Link = screen.getByRole('link', {name: 'O Organization 1'});
132132
expect(org1Link).toBeInTheDocument();
133133
// Current hostname in the URL is expected to be org2.sentry.io, so we need to make use of sentryUrl to link to an
134134
// organization that does not support customer domains.
@@ -137,7 +137,7 @@ describe('SwitchOrganization', function () {
137137
'https://sentry.io/organizations/org1/issues/'
138138
);
139139

140-
const org2Link = screen.getByRole('link', {name: 'org2 Organization 2'});
140+
const org2Link = screen.getByRole('link', {name: 'O Organization 2'});
141141
expect(org2Link).toBeInTheDocument();
142142
expect(org2Link).toHaveAttribute(
143143
'href',
@@ -180,11 +180,11 @@ describe('SwitchOrganization', function () {
180180

181181
expect(screen.getByRole('list')).toBeInTheDocument();
182182

183-
const org1Link = screen.getByRole('link', {name: 'org1 Organization 1'});
183+
const org1Link = screen.getByRole('link', {name: 'O Organization 1'});
184184
expect(org1Link).toBeInTheDocument();
185185
expect(org1Link).toHaveAttribute('href', '/organizations/org1/issues/');
186186

187-
const org3Link = screen.getByRole('link', {name: 'org3 Organization 3'});
187+
const org3Link = screen.getByRole('link', {name: 'O Organization 3'});
188188
expect(org3Link).toBeInTheDocument();
189189
expect(org3Link).toHaveAttribute(
190190
'href',

0 commit comments

Comments
 (0)