-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Allow to define pluggable integrations for loader #47540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Also note that currently lazy-loading and avoiding sentry scripts being ad-blocked is problematic due to inability to set SDK bundle url: getsentry/sentry-javascript#7288. Regular sentry CDN urls can be blocked by ad-blocker thus preventing SDK to load. This can be solved by serving SDK from the own host or using reverse proxy to change URL, e.g I guess loading integrations by the loader might further complicate this, as there will be more urls to handle (and those additional urls might be dynamically built preventing them to be replaced by reverse proxy as we currently do). I currently have no idea how this could be handled, but I guess again via some |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Problem Statement
Currently, when using the loader, the only way to get pluggable integrations working is to load them in addition to the loader script from the CDN.
However, this is brittle, because for the CDN you'll have to define an exact version, while the loader will always load the latest SDK version. This can lead to the case where the integration version becomes incompatible with the main SDK version, as we generally assume these are in sync.
See also getsentry/sentry-javascript#2476 (comment)
Solution Brainstorm
We should allow a way to define integrations to load for the loader. For example, something like this:
We could then make sure to load the correct version of the integration in the loader script.
The text was updated successfully, but these errors were encountered: