feat(explore-suspect-attrs): Positioning floating trigger to the bottom right

[Abdkhan14]

Always positioning at the bottom right prevents the trigger from covering the selected region.

Screen.Recording.2025-07-05.at.10.32.02.PM.mov

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #94939      +/-   ##
==========================================
- Coverage   87.93%   87.88%   -0.05%     
==========================================
  Files       10455    10449       -6     
  Lines      606439   604333    -2106     
  Branches    23550    23547       -3     
==========================================
- Hits       533251   531105    -2146     
- Misses      72821    72861      +40     
  Partials      367      367              

[cursor]

Bug: Chart Hook Positioning and Null Handling Errors

The useChartBoxSelect hook has three issues:

1. chart.getDom() is used without a null check before calling getBoundingClientRect().
2. The return value of chart.convertToPixel() is destructured without a null check, which can cause a TypeError if it returns null.
3. The floatingTriggerPosition.left calculation omits window.scrollX, leading to incorrect positioning when the page is horizontally scrolled.

static/app/views/explore/hooks/useChartBoxSelect.tsx#L123-L136

sentry/static/app/views/explore/hooks/useChartBoxSelect.tsx

Lines 123 to 136 in 9c66878

	// absolutely position the floating CTAs.
	const [clamped_x1_pixels, clamped_y0_pixels] = chart.convertToPixel(
	{xAxisIndex: 0, yAxisIndex: 0},
	[clamped_x1, clamped_y0]
	);
	const chartRect = chart.getDom().getBoundingClientRect();
	if (chartRect) {
	setFloatingTriggerPosition({
	left: chartRect.left + clamped_x1_pixels,
	top: chartRect.top + clamped_y0_pixels + window.scrollY,
	});
	}

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎