diff --git a/src/sentry/static/sentry/app/views/releases/utils/sessionTerm.tsx b/src/sentry/static/sentry/app/views/releases/utils/sessionTerm.tsx index 46116cbc338a28..93346438764b6d 100644 --- a/src/sentry/static/sentry/app/views/releases/utils/sessionTerm.tsx +++ b/src/sentry/static/sentry/app/views/releases/utils/sessionTerm.tsx @@ -27,8 +27,10 @@ export const sessionTerm = { // This should never be used directly (except in tests) export const commonTermsDescription = { [SessionTerm.CRASHES]: t('Number of sessions with a crashed state'), - [SessionTerm.CRASH_FREE_USERS]: t('Number of unique users with non-crashed sessions'), - [SessionTerm.CRASH_FREE_SESSIONS]: t('Number of non-crashed sessions'), + [SessionTerm.CRASH_FREE_USERS]: t( + 'Percentage of unique users with non-crashed sessions' + ), + [SessionTerm.CRASH_FREE_SESSIONS]: t('Percentage of non-crashed sessions'), [SessionTerm.STABILITY]: t( 'The percentage of crash free sessions and how it has changed since the last period.' ), @@ -39,7 +41,7 @@ export const mobileTermsDescription = { [SessionTerm.CRASHED]: t( 'The process was terminated due to an unhandled exception or a request to the server that ended with an error' ), - [SessionTerm.CRASH_FREE_SESSIONS]: t('Number of unique sessions that did not crash'), + [SessionTerm.CRASH_FREE_SESSIONS]: t('Percentage of non-crashed sessions'), [SessionTerm.ABNORMAL]: t( 'An unknown session exit. Like due to loss of power or killed by the operating system' ), @@ -112,15 +114,15 @@ function getTermDescriptions(platform: PlatformKey | null) { return { ...commonTermsDescription, [SessionTerm.CRASHED]: t( - "During the session an error with mechanism.handled===false occurred calling the 'onerror' on 'unhandledrejection' handler" + 'During the session an unhandled global error/promise rejection occurred.' ), - [SessionTerm.ABNORMAL]: t('Non applicable for Javascript'), - [SessionTerm.HEALTHY]: t('No errors were captured during session life-time'), + [SessionTerm.ABNORMAL]: t('Non applicable for Javascript.'), + [SessionTerm.HEALTHY]: t('No errors were captured during session life-time.'), [SessionTerm.ERRORED]: t( - 'During the session at least one error occurred that did not bubble up to the global handler. The application loading process did not crash' + 'During the session at least one handled error occurred.' ), [SessionTerm.UNHANDLED]: - "An error was captured by the global 'onerror' or 'onunhandledrejection' handler", + "An error was captured by the global 'onerror' or 'onunhandledrejection' handler.", }; case 'apple-ios': case 'minidump': diff --git a/tests/js/spec/views/releases/utils/sessionTerm.spec.tsx b/tests/js/spec/views/releases/utils/sessionTerm.spec.tsx index 686b0e6e5ca281..b8bb0cb96c351e 100644 --- a/tests/js/spec/views/releases/utils/sessionTerm.spec.tsx +++ b/tests/js/spec/views/releases/utils/sessionTerm.spec.tsx @@ -488,7 +488,7 @@ describe('Release Health Session Term', function () { 'node-express' ); expect(crashedSessionTerm).toEqual( - "During the session an error with mechanism.handled===false occurred calling the 'onerror' on 'unhandledrejection' handler" + 'During the session an unhandled global error/promise rejection occurred.' ); // Crash Free Users @@ -510,7 +510,7 @@ describe('Release Health Session Term', function () { SessionTerm.ABNORMAL, 'node-express' ); - expect(abnormalSessionTerm).toEqual('Non applicable for Javascript'); + expect(abnormalSessionTerm).toEqual('Non applicable for Javascript.'); // Healthy const healthySessionTerm = getSessionTermDescription( @@ -518,7 +518,7 @@ describe('Release Health Session Term', function () { 'node-express' ); expect(healthySessionTerm).toEqual( - 'No errors were captured during session life-time' + 'No errors were captured during session life-time.' ); // Errored @@ -527,7 +527,7 @@ describe('Release Health Session Term', function () { 'node-express' ); expect(erroredSessionTerm).toEqual( - 'During the session at least one error occurred that did not bubble up to the global handler. The application loading process did not crash' + 'During the session at least one handled error occurred.' ); // Unhandled @@ -536,7 +536,7 @@ describe('Release Health Session Term', function () { 'node-express' ); expect(unhandledSessionTerm).toEqual( - "An error was captured by the global 'onerror' or 'onunhandledrejection' handler" + "An error was captured by the global 'onerror' or 'onunhandledrejection' handler." ); }); @@ -554,7 +554,7 @@ describe('Release Health Session Term', function () { 'javascript' ); expect(crashedSessionTerm).toEqual( - "During the session an error with mechanism.handled===false occurred calling the 'onerror' on 'unhandledrejection' handler" + 'During the session an unhandled global error/promise rejection occurred.' ); // Crash Free Users @@ -576,7 +576,7 @@ describe('Release Health Session Term', function () { SessionTerm.ABNORMAL, 'javascript' ); - expect(abnormalSessionTerm).toEqual('Non applicable for Javascript'); + expect(abnormalSessionTerm).toEqual('Non applicable for Javascript.'); // Healthy const healthySessionTerm = getSessionTermDescription( @@ -584,7 +584,7 @@ describe('Release Health Session Term', function () { 'javascript' ); expect(healthySessionTerm).toEqual( - 'No errors were captured during session life-time' + 'No errors were captured during session life-time.' ); // Errored @@ -593,7 +593,7 @@ describe('Release Health Session Term', function () { 'javascript' ); expect(erroredSessionTerm).toEqual( - 'During the session at least one error occurred that did not bubble up to the global handler. The application loading process did not crash' + 'During the session at least one handled error occurred.' ); // Unhandled @@ -602,7 +602,7 @@ describe('Release Health Session Term', function () { 'javascript' ); expect(unhandledSessionTerm).toEqual( - "An error was captured by the global 'onerror' or 'onunhandledrejection' handler" + "An error was captured by the global 'onerror' or 'onunhandledrejection' handler." ); });