Skip to content

Commit f928869

Browse files
committed
fix: Clippy 1.40.0
1 parent de12af6 commit f928869

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

common/src/cell.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,10 +245,14 @@ where
245245

246246
/// Unsafely creates a new `SelfCell` from a derived object by moving the owner.
247247
///
248+
/// # Safety
249+
///
248250
/// This is an inherently unsafe process. The caller must guarantee that the derived object only
249251
/// borrows from the owner that is moved into this container. This is useful, when cloning the
250252
/// owner by deriving a sub-object.
251253
///
254+
/// # Example
255+
///
252256
/// ```rust
253257
/// # use std::sync::Arc;
254258
/// # use symbolic_common::{AsSelf, SelfCell};

debuginfo/src/pdb.rs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
33
use std::borrow::Cow;
44
use std::cell::{RefCell, RefMut};
5+
use std::cmp::Ordering;
56
use std::collections::btree_map::{BTreeMap, Entry};
67
use std::fmt;
78
use std::io::Cursor;
@@ -392,11 +393,11 @@ where
392393

393394
while let Some(item) = self.iter.next()? {
394395
self.finder.update(&self.iter);
395-
if item.index() == index {
396-
return Ok(item);
397-
} else if item.index() > index {
398-
break;
399-
};
396+
match item.index().partial_cmp(&index) {
397+
Some(Ordering::Equal) => return Ok(item),
398+
Some(Ordering::Greater) => break,
399+
_ => continue,
400+
}
400401
}
401402

402403
Err(pdb::Error::TypeNotFound(index.into()).into())

demangle/src/lib.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,9 @@
1818
//! use symbolic_common::{Language, Name};
1919
//! use symbolic_demangle::Demangle;
2020
//!
21-
//! # fn main() {
2221
//! let name = Name::new("__ZN3std2io4Read11read_to_end17hb85a0f6802e14499E");
2322
//! assert_eq!(name.detect_language(), Language::Rust);
2423
//! assert_eq!(name.try_demangle(Default::default()), "std::io::Read::read_to_end");
25-
//! # }
2624
//! ```
2725
2826
#![warn(missing_docs)]

minidump/src/processor.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,11 @@ pub type ParseCodeModuleIdError = ParseDebugIdError;
9999
/// use symbolic_minidump::processor::CodeModuleId;
100100
/// # use symbolic_minidump::processor::ParseCodeModuleIdError;
101101
///
102-
/// # fn foo() -> Result<(), ParseCodeModuleIdError> {
102+
/// # fn main() -> Result<(), ParseCodeModuleIdError> {
103103
/// let id = CodeModuleId::from_str("DFB8E43AF2423D73A453AEB6A777EF75a")?;
104104
/// assert_eq!("DFB8E43AF2423D73A453AEB6A777EF75a".to_string(), id.to_string());
105105
/// # Ok(())
106106
/// # }
107-
///
108-
/// # fn main() { foo().unwrap() }
109107
/// ```
110108
#[derive(Debug, Default, Eq, PartialEq, Ord, PartialOrd, Hash, Clone, Copy)]
111109
pub struct CodeModuleId {

0 commit comments

Comments
 (0)