Build failure on `kokkos_assembly.cpp` #1580

fvanmaele · 2024-03-26T11:45:48Z

fvanmaele
Mar 26, 2024

I get the following error:

[ 98%] Linking CXX executable custom-matrix-format
/home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp: In lambda function:
/home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp:127:43: error: ‘abs’ is not a member of ‘Kokkos::Experimental’
  127 |             lsum += Kokkos::Experimental::abs(
      |                                           ^~~
/home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp:127:43: note: suggested alternatives:
In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/cstdlib:77,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/ext/string_conversions.h:41,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/bits/basic_string.h:6608,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/string:55,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/bits/locale_classes.h:40,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/bits/ios_base.h:41,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/ios:42,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/ostream:38,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/iostream:39,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp:33:
/usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/bits/std_abs.h:56:3: note:   ‘abs’
   56 |   abs(long __i) { return __builtin_labs(__i); }
      |   ^~~
In file included from /usr/include/Kokkos_Complex.hpp:28,
                 from /usr/include/Kokkos_MathematicalSpecialFunctions.hpp:31,
                 from /usr/include/Kokkos_Core.hpp:54,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp:39:
/usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/complex:626:5: note:   ‘std::abs’
  626 |     abs(const complex<_Tp>& __z) { return __complex_abs(__z.__rep()); }
      |     ^~~
In file included from /usr/include/Kokkos_MathematicalSpecialFunctions.hpp:31,
                 from /usr/include/Kokkos_Core.hpp:54,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp:39:
/usr/include/Kokkos_Complex.hpp:677:33: note:   ‘Kokkos::abs’
  677 | KOKKOS_INLINE_FUNCTION RealType abs(const complex<RealType>& x) {
      |                                 ^~~
In file included from /home/archie/source/repos/asc-installer/dependencies/ginkgo/include/ginkgo/core/base/matrix_data.hpp:45,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/include/ginkgo/core/base/mtx_io.hpp:40,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/include/ginkgo/core/base/batch_multi_vector.hpp:45,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/include/ginkgo/core/base/batch_lin_op.hpp:43,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/include/ginkgo/ginkgo.hpp:43,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp:40:
/home/archie/source/repos/asc-installer/dependencies/ginkgo/include/ginkgo/core/base/range.hpp:727:49: note:   ‘gko::abs’
  727 | GKO_ENABLE_UNARY_RANGE_OPERATION(abs_operation, abs,
      |                                                 ^~~
/home/archie/source/repos/asc-installer/dependencies/ginkgo/include/ginkgo/core/base/range.hpp:648:9: note: in definition of macro ‘GKO_BIND_UNARY_RANGE_OPERATION_TO_OPERATOR’
  648 |         _operator_name(const range<Accessor>& operand)                       \
      |         ^~~~~~~~~~~~~~
/home/archie/source/repos/asc-installer/dependencies/ginkgo/include/ginkgo/core/base/range.hpp:727:1: note: in expansion of macro ‘GKO_ENABLE_UNARY_RANGE_OPERATION’
  727 | GKO_ENABLE_UNARY_RANGE_OPERATION(abs_operation, abs,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/mutex:39,
                 from /usr/include/Serial/Kokkos_Serial.hpp:33,
                 from /usr/include/decl/Kokkos_Declare_SERIAL.hpp:21,
                 from /usr/include/KokkosCore_Config_DeclareBackend.hpp:22,
                 from /usr/include/Kokkos_Core.hpp:45,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp:39:
/usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/chrono:393:7: note:   ‘std::chrono::abs’
  393 |       abs(duration<_Rep, _Period> __d)
      |       ^~~
In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/cstdlib:75,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/ext/string_conversions.h:41,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/bits/basic_string.h:6608,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/string:55,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/bits/locale_classes.h:40,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/bits/ios_base.h:41,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/ios:42,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/ostream:38,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/iostream:39,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp:33:
/usr/include/stdlib.h:980:12: note:   ‘std::abs’
  980 | extern int abs (int __x) __THROW __attribute__ ((__const__)) __wur;
      |            ^~~
/usr/include/stdlib.h:980:12: note:   ‘std::abs’
/usr/include/stdlib.h:980:12: note:   ‘std::abs’
/usr/include/stdlib.h:980:12: note:   ‘std::abs’
/usr/include/stdlib.h:980:12: note:   ‘std::abs’
/home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp:129:39: error: ‘abs’ is not a member of ‘Kokkos::Experimental’
  129 |                 Kokkos::Experimental::abs(correct_u(xi)));
      |                                       ^~~
/home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp:129:39: note: suggested alternatives:
In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/cstdlib:77,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/ext/string_conversions.h:41,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/bits/basic_string.h:6608,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/string:55,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/bits/locale_classes.h:40,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/bits/ios_base.h:41,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/ios:42,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/ostream:38,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/iostream:39,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp:33:
/usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/bits/std_abs.h:56:3: note:   ‘abs’
   56 |   abs(long __i) { return __builtin_labs(__i); }
      |   ^~~
In file included from /usr/include/Kokkos_Complex.hpp:28,
                 from /usr/include/Kokkos_MathematicalSpecialFunctions.hpp:31,
                 from /usr/include/Kokkos_Core.hpp:54,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp:39:
/usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/complex:626:5: note:   ‘std::abs’
  626 |     abs(const complex<_Tp>& __z) { return __complex_abs(__z.__rep()); }
      |     ^~~
In file included from /usr/include/Kokkos_MathematicalSpecialFunctions.hpp:31,
                 from /usr/include/Kokkos_Core.hpp:54,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp:39:
/usr/include/Kokkos_Complex.hpp:677:33: note:   ‘Kokkos::abs’
  677 | KOKKOS_INLINE_FUNCTION RealType abs(const complex<RealType>& x) {
      |                                 ^~~
In file included from /home/archie/source/repos/asc-installer/dependencies/ginkgo/include/ginkgo/core/base/matrix_data.hpp:45,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/include/ginkgo/core/base/mtx_io.hpp:40,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/include/ginkgo/core/base/batch_multi_vector.hpp:45,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/include/ginkgo/core/base/batch_lin_op.hpp:43,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/include/ginkgo/ginkgo.hpp:43,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp:40:
/home/archie/source/repos/asc-installer/dependencies/ginkgo/include/ginkgo/core/base/range.hpp:727:49: note:   ‘gko::abs’
  727 | GKO_ENABLE_UNARY_RANGE_OPERATION(abs_operation, abs,
      |                                                 ^~~
/home/archie/source/repos/asc-installer/dependencies/ginkgo/include/ginkgo/core/base/range.hpp:648:9: note: in definition of macro ‘GKO_BIND_UNARY_RANGE_OPERATION_TO_OPERATOR’
  648 |         _operator_name(const range<Accessor>& operand)                       \
      |         ^~~~~~~~~~~~~~
/home/archie/source/repos/asc-installer/dependencies/ginkgo/include/ginkgo/core/base/range.hpp:727:1: note: in expansion of macro ‘GKO_ENABLE_UNARY_RANGE_OPERATION’
  727 | GKO_ENABLE_UNARY_RANGE_OPERATION(abs_operation, abs,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/mutex:39,
                 from /usr/include/Serial/Kokkos_Serial.hpp:33,
                 from /usr/include/decl/Kokkos_Declare_SERIAL.hpp:21,
                 from /usr/include/KokkosCore_Config_DeclareBackend.hpp:22,
                 from /usr/include/Kokkos_Core.hpp:45,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp:39:
/usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/chrono:393:7: note:   ‘std::chrono::abs’
  393 |       abs(duration<_Rep, _Period> __d)
      |       ^~~
In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/cstdlib:75,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/ext/string_conversions.h:41,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/bits/basic_string.h:6608,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/string:55,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/bits/locale_classes.h:40,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/bits/ios_base.h:41,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/ios:42,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/ostream:38,
                 from /usr/lib/gcc/x86_64-pc-linux-gnu/11.4.0/include/c++/iostream:39,
                 from /home/archie/source/repos/asc-installer/dependencies/ginkgo/examples/kokkos_assembly/kokkos_assembly.cpp:33:
/usr/include/stdlib.h:980:12: note:   ‘std::abs’
  980 | extern int abs (int __x) __THROW __attribute__ ((__const__)) __wur;
      |            ^~~
/usr/include/stdlib.h:980:12: note:   ‘std::abs’
/usr/include/stdlib.h:980:12: note:   ‘std::abs’
/usr/include/stdlib.h:980:12: note:   ‘std::abs’
/usr/include/stdlib.h:980:12: note:   ‘std::abs’
[ 98%] Built target custom-matrix-format
[ 98%] Linking CXX executable simple-solver-logging
[ 98%] Built target simple-solver-logging
make[2]: *** [examples/kokkos_assembly/CMakeFiles/kokkos-assembly.dir/build.make:76: examples/kokkos_assembly/CMakeFiles/kokkos-assembly.dir/kokkos_assembly.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:3853: examples/kokkos_assembly/CMakeFiles/kokkos-assembly.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 98%] Linking CXX executable preconditioner-export
[ 98%] Built target preconditioner-export
[100%] Linking CXX executable distributed-solver
[100%] Built target distributed-solver
make: *** [Makefile:156: all] Error 2

CUDA 11.7, g++ (Arch) 11.4.0, trilinos 15.0.0

cmake -L output:

BUILD_SHARED_LIBS:BOOL=ON
BUILD_TESTING:BOOL=ON
CCACHE_PROGRAM:FILEPATH=CCACHE_PROGRAM-NOTFOUND
CMAKE_BUILD_TYPE:STRING=RelWithDebInfo
CMAKE_CXX_EXTENSIONS:BOOL=OFF
CMAKE_INSTALL_PREFIX:PATH=/home/archie/install
GINKGO_BENCHMARK_ENABLE_TUNING:BOOL=OFF
GINKGO_BUILD_BENCHMARKS:BOOL=OFF
GINKGO_BUILD_CUDA:BOOL=ON
GINKGO_BUILD_DOC:BOOL=OFF
GINKGO_BUILD_EXAMPLES:BOOL=ON
GINKGO_BUILD_EXTLIB_EXAMPLE:BOOL=OFF
GINKGO_BUILD_HIP:BOOL=OFF
GINKGO_BUILD_HWLOC:BOOL=ON
GINKGO_BUILD_MPI:BOOL=ON
GINKGO_BUILD_OMP:BOOL=ON
GINKGO_BUILD_PAPI_SDE:BOOL=OFF
GINKGO_BUILD_REFERENCE:BOOL=ON
GINKGO_BUILD_SYCL:BOOL=OFF
GINKGO_BUILD_TESTS:BOOL=OFF
GINKGO_CHECK_CIRCULAR_DEPS:BOOL=OFF
GINKGO_CI_TEST_OMP_PARALLELISM:STRING=4
GINKGO_COMPILER_FLAGS:STRING=-Wpedantic
GINKGO_CONFIG_LOG_DETAILED:BOOL=OFF
GINKGO_CUDA_ARCHITECTURES:STRING=Auto
GINKGO_CUDA_COMPILER_FLAGS:STRING=
GINKGO_DEVEL_TOOLS:BOOL=OFF
GINKGO_DPCPP_SINGLE_MODE:BOOL=OFF
GINKGO_EXPORT_BUILD_DIR:BOOL=OFF
GINKGO_FAST_TESTS:BOOL=OFF
GINKGO_FORCE_GPU_AWARE_MPI:BOOL=OFF
GINKGO_HIPCONFIG_PATH:FILEPATH=GINKGO_HIPCONFIG_PATH-NOTFOUND
GINKGO_HIP_AMDGPU:STRING=
GINKGO_HIP_AMD_UNSAFE_ATOMIC:BOOL=ON
GINKGO_HIP_CLANG_COMPILER_FLAGS:STRING=
GINKGO_HIP_COMPILER_FLAGS:STRING=
GINKGO_HIP_NVCC_COMPILER_FLAGS:STRING=
GINKGO_INSTALL_RPATH:BOOL=ON
GINKGO_INSTALL_RPATH_DEPENDENCIES:BOOL=OFF
GINKGO_INSTALL_RPATH_ORIGIN:BOOL=ON
GINKGO_JACOBI_FULL_OPTIMIZATIONS:BOOL=OFF
GINKGO_MIXED_PRECISION:BOOL=OFF
GINKGO_RUN_EXAMPLES:BOOL=ON
GINKGO_SKIP_DEPENDENCY_UPDATE:BOOL=ON
GINKGO_TEST_NONDEFAULT_STREAM:BOOL=OFF
GINKGO_VERBOSE_LEVEL:STRING=1
GINKGO_WITH_CCACHE:BOOL=OFF
GINKGO_WITH_CLANG_TIDY:BOOL=OFF
GINKGO_WITH_IWYU:BOOL=OFF
GTest_DIR:PATH=/usr/lib/cmake/GTest
Ginkgo_ASAN_SUPPORTED:STRING=TRUE
Ginkgo_COVERAGE_SUPPORTED:STRING=TRUE
Ginkgo_LSAN_SUPPORTED:STRING=TRUE
HIP_PATH:PATH=/opt/rocm/hip
Kokkos_DIR:PATH=/usr/lib/cmake/Kokkos
METIS_INCLUDE_DIR:PATH=/usr/include
METIS_LIBRARY:FILEPATH=/usr/lib/libmetis.so
NUMA_LIBRARY:FILEPATH=/usr/lib/libnuma.so
NUMA_ROOT_DIR:PATH=/usr
OpenCV_DIR:PATH=OpenCV_DIR-NOTFOUND
PerfStubs_DIR:PATH=PerfStubs_DIR-NOTFOUND
VTune_EXECUTABLE:FILEPATH=VTune_EXECUTABLE-NOTFOUND
VTune_LIBRARY:FILEPATH=VTune_LIBRARY-NOTFOUND
gflags_DIR:PATH=/usr/lib/cmake/gflags
nlohmann_json_DIR:PATH=/usr/share/cmake/nlohmann_json

MarcelKoch · 2024-03-26T12:10:09Z

MarcelKoch
Mar 26, 2024
Maintainer

This issue is known. It is due to interface changes from Kokkos 3.x to 4.x. The current example only works with Kokkos < 4.0, but there will be an overhaul in the next release.

2 replies

yhmtsai Mar 26, 2024
Collaborator

maybe we can create a small pr to specify the kokkos version 3.x now and then when we adapt the version 4 for changing it?

MarcelKoch Mar 26, 2024
Maintainer

You're right, it shouldn't be too much to change.

tcojean · 2024-05-29T16:32:35Z

tcojean
May 29, 2024
Maintainer

FYI, as we are preparing the next release, this should have been fixed in develop and will be propagated to the next version.

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Build failure on `kokkos_assembly.cpp` #1580

Uh oh!

{{title}}

Uh oh!

Replies: 2 comments 2 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Build failure on kokkos_assembly.cpp #1580

Uh oh!

fvanmaele Mar 26, 2024

Replies: 2 comments · 2 replies

Uh oh!

MarcelKoch Mar 26, 2024 Maintainer

Uh oh!

yhmtsai Mar 26, 2024 Collaborator

Uh oh!

MarcelKoch Mar 26, 2024 Maintainer

Uh oh!

tcojean May 29, 2024 Maintainer

Build failure on `kokkos_assembly.cpp` #1580

fvanmaele
Mar 26, 2024

Replies: 2 comments 2 replies

MarcelKoch
Mar 26, 2024
Maintainer

yhmtsai Mar 26, 2024
Collaborator

MarcelKoch Mar 26, 2024
Maintainer

tcojean
May 29, 2024
Maintainer