Skip to content

Add Test Coverage metrics to GCMC code repository #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mminns opened this issue Oct 19, 2021 · 4 comments
Closed

Add Test Coverage metrics to GCMC code repository #498

mminns opened this issue Oct 19, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@mminns
Copy link
Contributor

mminns commented Oct 19, 2021

Feature description

No (?) tests for the Bitbucket code were migrated from the GCMW, minimal tests have since been added.

I'd like to potentially refactor the Bitbucket code, but would like to add more tests first. Test Coverage metrics would help to identify areas in need of new tests.

Potential Solution

Coverlet and the configuration described here https://josh-ops.com/posts/github-code-coverage/ would ultimately lead to an environment where

  • Coverage metrics are generated during CI
  • Coverage metrics are reported on the repo and during PRs
  • Potentially enforce/increase a minimal coverage level.

However this configuration is dependent on a single file of coverage metrics, this is currently not possible using Coverlet, coverlet-coverage/coverlet#1015 (comment)

Intermediate Solution

It would be possible to add Coverlet to the project and incrementally move to the final desired state.

MVP

  • Add Coverlet to the project to generate metrics
  • Add ReportGenerator to the project to generate HTML reports of the metrics
  • Add documentation on how to generate a coverage report

CI

  • Extend CI configuration to generate Coverage Report
  • Make the report accessible as an artefact from CI

Full integration

@mminns mminns added the enhancement New feature or request label Oct 19, 2021
@mminns
Copy link
Contributor Author

mminns commented Oct 19, 2021

First pass implementation is here #499

@mminns
Copy link
Contributor Author

mminns commented Mar 17, 2022

#499 merged code coverage.

#607 refactors the Bitbucket tests

@ldennington
Copy link
Contributor

Hey @mminns! Did you have any additional plans to extend test coverage/update more tests, or are we ok to close this issue?

@ldennington
Copy link
Contributor

Closing - can re-open if we decide to add additional coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants