Skip to content

Fix GitHub Enterprise API URL for raw source code links #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ejball opened this issue Jan 5, 2022 · 2 comments
Closed

Fix GitHub Enterprise API URL for raw source code links #598

ejball opened this issue Jan 5, 2022 · 2 comments
Labels
enhancement New feature or request external Relating to an external partner, team, or library host:github Specific to the GitHub host provider

Comments

@ejball
Copy link
Contributor

ejball commented Jan 5, 2022

When storing credentials for raw URLs of GitHub Enterprise instances (as Visual Studio does when Fall back to Git Credential Manager authentication for all Source Link requests is enabled), the GitHub Enterprise API hostname does not necessarily match the raw URL hostname. For example, a raw URL of https://raw.my.ghe.dev/... should access the API at https://my.ghe.dev/api/v3. For our purposes, removing raw. from the hostname would fix the issue, but perhaps some sort of configuration is necessary in the general case.

@ejball
Copy link
Contributor Author

ejball commented Jan 5, 2022

Source Link supports this via the ContentUrl attribute of SourceLinkGitHubHost (GHE usage mentioned here).

@mjcheetham mjcheetham added external Relating to an external partner, team, or library host:github Specific to the GitHub host provider labels Jan 6, 2022
@mjcheetham
Copy link
Collaborator

This should have been fixed after #599 was merged. This feature will go out in the next GCM release - watch this space!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external Relating to an external partner, team, or library host:github Specific to the GitHub host provider
Projects
None yet
Development

No branches or pull requests

2 participants