Skip to content

Commit 00d75ec

Browse files
dsl101Git for Windows Build Agent
authored and
Git for Windows Build Agent
committed
mingw: suggest windows.appendAtomically in more cases
When running Git for Windows on a remote APFS filesystem, it would appear that the `mingw_open_append()`/`write()` combination would fail almost exactly like on some CIFS-mounted shares as had been reported in #2753, albeit with a different `errno` value. Let's handle that `errno` value just the same, by suggesting to set `windows.appendAtomically=false`. Signed-off-by: David Lomas <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 81f9677 commit 00d75ec

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

compat/mingw.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -810,7 +810,7 @@ ssize_t mingw_write(int fd, const void *buf, size_t len)
810810
{
811811
ssize_t result = write(fd, buf, len);
812812

813-
if (result < 0 && (errno == EINVAL || errno == ENOSPC) && buf) {
813+
if (result < 0 && (errno == EINVAL || errno == EBADF || errno == ENOSPC) && buf) {
814814
int orig = errno;
815815

816816
/* check if fd is a pipe */
@@ -836,7 +836,7 @@ ssize_t mingw_write(int fd, const void *buf, size_t len)
836836
}
837837

838838
errno = orig;
839-
} else if (orig == EINVAL)
839+
} else if (orig == EINVAL || errno == EBADF)
840840
errno = EPIPE;
841841
else {
842842
DWORD buf_size;

0 commit comments

Comments
 (0)