mingw: avoid a buffer overrun in needs_hiding()

dscho · SyntevoAlex · dscho · commit 0b6a19e484f2 · 2019-10-25T15:18:08.000+02:00
When this function is passed a path with a trailing slash, it runs right
over the end of that path.

Let's fix this.

Co-authored-by: Alexandr Miloslavskiy &lt;alexandr.miloslavskiy@syntevo.com&gt;
Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
diff --git a/compat/mingw.c b/compat/mingw.c
@@ -591,6 +591,8 @@ static inline int needs_hiding(const char *path)
 			/* ignore trailing slashes */
 			if (*path)
 				basename = path;
+			else
+				break;
 		}
 
 	if (hide_dotfiles == HIDE_DOTFILES_TRUE)

Original file line number	Diff line number	Diff line change
`@@ -591,6 +591,8 @@ static inline int needs_hiding(const char *path)`
`591`	`591`	`/* ignore trailing slashes */`
`592`	`592`	`if (*path)`
`593`	`593`	`basename = path;`
	`594`	`+ else`
	`595`	`+ break;`
`594`	`596`	`}`
`595`	`597`
`596`	`598`	`if (hide_dotfiles == HIDE_DOTFILES_TRUE)`