Skip to content

Commit 339727c

Browse files
dschoGit for Windows Build Agent
authored and
Git for Windows Build Agent
committed
mingw: enable stack smashing protector
As suggested privately to Brendan Forster by some unnamed person (suggestion for the future: use the public mailing list, or even the public GitHub issue tracker, that is a much better place to offer such suggestions), we should make use of gcc's stack smashing protector that helps detect stack buffer overruns early. Rather than using -fstack-protector, we use -fstack-protector-strong because it strikes a better balance between how much code is affected and the performance impact. In a local test (time git log --grep=is -p), best of 5 timings went from 23.009s to 22.997s (i.e. the performance impact was *well* lost in the noise). This fixes #501 Signed-off-by: Johannes Schindelin <[email protected]>
1 parent d012953 commit 339727c

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

config.mak.uname

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,8 @@ else
596596
BASIC_LDFLAGS += -Wl,--large-address-aware
597597
endif
598598
CC = gcc
599-
COMPAT_CFLAGS += -D__USE_MINGW_ANSI_STDIO=0 -DDETECT_MSYS_TTY
599+
COMPAT_CFLAGS += -D__USE_MINGW_ANSI_STDIO=0 -DDETECT_MSYS_TTY \
600+
-fstack-protector-strong
600601
EXTLIBS += -lntdll
601602
INSTALL = /bin/install
602603
NO_R_TO_GCC_LINKER = YesPlease

0 commit comments

Comments
 (0)