Skip to content

Commit 3a32c91

Browse files
dennisamelingGit for Windows Build Agent
authored and
Git for Windows Build Agent
committed
cmake(windows): set correct path to the system Git config
Currently, when Git for Windows is built with CMake, the system Git config is expected in a different location than when building via `make`: the former expects it to be in `<runtime-prefix>/mingw64/etc/gitconfig`, the latter in `<runtime-prefix>/etc/gitconfig`. Because of this, things like `git clone` do not work correctly (because cURL is no longer able to find its certificate bundle that it needs to validate HTTPS certificates). See the full bug report and discussion here: #3071 (comment). This commit aligns the CMake-based build by mimicking what is already done in `config.mak.uname`. This closes #3071. Signed-off-by: Dennis Ameling <[email protected]>
1 parent fc38f38 commit 3a32c91

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

contrib/buildsystems/CMakeLists.txt

+7-4
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,6 @@ list(APPEND compat_SOURCES sha1dc_git.c sha1dc/sha1.c sha1dc/ubc_check.c block-s
204204

205205

206206
add_compile_definitions(PAGER_ENV="LESS=FRX LV=-c"
207-
ETC_GITATTRIBUTES="etc/gitattributes"
208-
ETC_GITCONFIG="etc/gitconfig"
209207
GIT_EXEC_PATH="libexec/git-core"
210208
GIT_LOCALE_PATH="share/locale"
211209
GIT_MAN_PATH="share/man"
@@ -220,10 +218,15 @@ add_compile_definitions(PAGER_ENV="LESS=FRX LV=-c"
220218

221219
if(WIN32)
222220
set(FALLBACK_RUNTIME_PREFIX /mingw64)
223-
add_compile_definitions(FALLBACK_RUNTIME_PREFIX="${FALLBACK_RUNTIME_PREFIX}")
221+
# Move system config into top-level /etc/
222+
add_compile_definitions(FALLBACK_RUNTIME_PREFIX="${FALLBACK_RUNTIME_PREFIX}"
223+
ETC_GITATTRIBUTES="../etc/gitattributes"
224+
ETC_GITCONFIG="../etc/gitconfig")
224225
else()
225226
set(FALLBACK_RUNTIME_PREFIX /home/$ENV{USER})
226-
add_compile_definitions(FALLBACK_RUNTIME_PREFIX="${FALLBACK_RUNTIME_PREFIX}")
227+
add_compile_definitions(FALLBACK_RUNTIME_PREFIX="${FALLBACK_RUNTIME_PREFIX}"
228+
ETC_GITATTRIBUTES="etc/gitattributes"
229+
ETC_GITCONFIG="etc/gitconfig")
227230
endif()
228231

229232

0 commit comments

Comments
 (0)