Skip to content

Commit 5ac3aeb

Browse files
dsl101dscho
authored andcommitted
mingw: suggest windows.appendAtomically in more cases
When running Git for Windows on a remote APFS filesystem, it would appear that the `mingw_open_append()`/`write()` combination would fail almost exactly like on some CIFS-mounted shares as had been reported in #2753, albeit with a different `errno` value. Let's handle that `errno` value just the same, by suggesting to set `windows.appendAtomically=false`. Signed-off-by: David Lomas <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 7486396 commit 5ac3aeb

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

compat/mingw.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -720,7 +720,7 @@ ssize_t mingw_write(int fd, const void *buf, size_t len)
720720
{
721721
ssize_t result = write(fd, buf, len);
722722

723-
if (result < 0 && (errno == EINVAL || errno == ENOSPC) && buf) {
723+
if (result < 0 && (errno == EINVAL || errno == EBADF || errno == ENOSPC) && buf) {
724724
int orig = errno;
725725

726726
/* check if fd is a pipe */
@@ -746,7 +746,7 @@ ssize_t mingw_write(int fd, const void *buf, size_t len)
746746
}
747747

748748
errno = orig;
749-
} else if (orig == EINVAL)
749+
} else if (orig == EINVAL || errno == EBADF)
750750
errno = EPIPE;
751751
else {
752752
DWORD buf_size;

0 commit comments

Comments
 (0)