Skip to content

Commit 79682c9

Browse files
committed
fixup! rebase -r: let label generate safer labels
Let's revert that Windows-only patch in favor of the version that made it upstream. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 992f077 commit 79682c9

File tree

2 files changed

+1
-17
lines changed

2 files changed

+1
-17
lines changed

sequencer.c

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4598,18 +4598,8 @@ static int make_script_with_merges(struct pretty_print_context *pp,
45984598
else
45994599
strbuf_addbuf(&label, &oneline);
46004600

4601-
/*
4602-
* Sanitize labels by replacing non-alpha-numeric characters
4603-
* (including white-space ones) by dashes, as they might be
4604-
* illegal in file names (and hence in ref names).
4605-
*
4606-
* Note that we retain non-ASCII UTF-8 characters (identified
4607-
* via the most significant bit). They should be all acceptable
4608-
* in file names. We do not validate the UTF-8 here, that's not
4609-
* the job of this function.
4610-
*/
46114601
for (p1 = label.buf; *p1; p1++)
4612-
if (!(*p1 & 0x80) && !isalnum(*p1))
4602+
if (isspace(*p1))
46134603
*(char *)p1 = '-';
46144604

46154605
strbuf_reset(&buf);

t/t3430-rebase-merges.sh

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -468,10 +468,4 @@ test_expect_success '--rebase-merges with strategies' '
468468
test_cmp expect G.t
469469
'
470470

471-
test_expect_success '--rebase-merges with commit that can generate bad characters for filename' '
472-
git checkout -b colon-in-label E &&
473-
git merge -m "colon: this should work" G &&
474-
git rebase --rebase-merges --force-rebase E
475-
'
476-
477471
test_done

0 commit comments

Comments
 (0)