Merge pull request #2371 from dscho/fix-needs-hiding-buffer-overrun

dscho · dscho · commit 9337df028e6c · 2019-11-16T22:26:24.000+01:00
Avoid a buffer overrun in `needs_hiding()`
diff --git a/compat/mingw.c b/compat/mingw.c
@@ -376,6 +376,8 @@ static inline int needs_hiding(const char *path)
 			/* ignore trailing slashes */
 			if (*path)
 				basename = path;
+			else
+				break;
 		}
 
 	if (hide_dotfiles == HIDE_DOTFILES_TRUE)

Original file line number	Diff line number	Diff line change
`@@ -376,6 +376,8 @@ static inline int needs_hiding(const char *path)`
`376`	`376`	`/* ignore trailing slashes */`
`377`	`377`	`if (*path)`
`378`	`378`	`basename = path;`
	`379`	`+ else`
	`380`	`+ break;`
`379`	`381`	`}`
`380`	`382`
`381`	`383`	`if (hide_dotfiles == HIDE_DOTFILES_TRUE)`