Stop using nedmalloc on Windows

Nedmalloc has been EOL for a while according to its author (ned14/nedmalloc#20 (comment)):

"nedmalloc is pretty much EOL. Happy to accept patches, but unwilling to fix. You should use the system allocator on any recent OS instead."

It was also leading to compilation errors to ARM64 using llvm-mingw on Windows:

In file included from F:\git-sdk-64\usr\src\git\compat\nedmalloc\nedmalloc.c:63:
F:\git-sdk-64\usr\src\git\compat\nedmalloc/malloc.c.h:1404:57: error: static declaration of '_InterlockedExchange' follows non-static declaration
  static __inline__ __attribute__((always_inline)) long _InterlockedExchange(volatile long * const Target, const long Value)

Git will now use the built-in OS memory allocation on Windows instead.

Signed-off-by: Dennis Ameling <[email protected]>

Author: dennisameling

contrib/buildsystems/CMakeLists.txt

@@ -284,12 +284,12 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
 	add_compile_definitions(HAVE_ALLOCA_H NO_POSIX_GOODIES NATIVE_CRLF NO_UNIX_SOCKETS WIN32
 				_CONSOLE DETECT_MSYS_TTY STRIP_EXTENSION=".exe"  NO_SYMLINK_HEAD UNRELIABLE_FSTAT
 				NOGDI OBJECT_CREATION_MODE=1 __USE_MINGW_ANSI_STDIO=0
-				USE_NED_ALLOCATOR OVERRIDE_STRDUP MMAP_PREVENTS_DELETE USE_WIN32_MMAP
+				OVERRIDE_STRDUP MMAP_PREVENTS_DELETE USE_WIN32_MMAP
 				UNICODE _UNICODE HAVE_WPGMPTR ENSURE_MSYSTEM_IS_SET)
 	list(APPEND compat_SOURCES compat/mingw.c compat/winansi.c compat/win32/path-utils.c
 		compat/win32/pthread.c compat/win32mmap.c compat/win32/syslog.c
 		compat/win32/trace2_win32_process_info.c compat/win32/dirent.c
-		compat/nedmalloc/nedmalloc.c compat/strdup.c compat/win32/fscache.c)
+		compat/strdup.c compat/win32/fscache.c)
 	set(NO_UNIX_SOCKETS 1)
 
 elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux")