diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h index 11383eb5f4d823..c6cb8dd2190062 100644 --- a/compat/win32/pthread.h +++ b/compat/win32/pthread.h @@ -34,17 +34,6 @@ typedef int pthread_mutexattr_t; #define pthread_cond_t CONDITION_VARIABLE -WINBASEAPI VOID WINAPI -InitializeConditionVariable(PCONDITION_VARIABLE ConditionVariable); -WINBASEAPI VOID WINAPI -WakeConditionVariable(PCONDITION_VARIABLE ConditionVariable); -WINBASEAPI VOID WINAPI -WakeAllConditionVariable(PCONDITION_VARIABLE ConditionVariable); -WINBASEAPI BOOL WINAPI -SleepConditionVariableCS(PCONDITION_VARIABLE ConditionVariable, - PCRITICAL_SECTION CriticalSection, - DWORD dwMilliseconds); - #define pthread_cond_init(a,b) InitializeConditionVariable((a)) #define pthread_cond_destroy(a) do {} while (0) #define pthread_cond_wait(a,b) return_0(SleepConditionVariableCS((a), (b), INFINITE)) diff --git a/config.c b/config.c index 1a0e950c3ca363..790a4547d7731e 100644 --- a/config.c +++ b/config.c @@ -1669,7 +1669,7 @@ static int do_git_config_sequence(const struct config_options *opts, if (opts->commondir) repo_config = mkpathdup("%s/config", opts->commondir); else if (opts->git_dir) - repo_config = mkpathdup("%s/config", opts->git_dir); + BUG("git_dir without commondir"); else repo_config = NULL; diff --git a/http.c b/http.c index 0ebf8f77a6d20b..43e75ac583b428 100644 --- a/http.c +++ b/http.c @@ -835,7 +835,7 @@ static CURL *get_curl_handle(void) curl_easy_setopt(result, CURLOPT_SSL_OPTIONS, CURLSSLOPT_NO_REVOKE); #else warning("CURLSSLOPT_NO_REVOKE not applied to curl SSL options because\n" - "your curl version is too old (>= 7.44.0)"); + "your curl version is too old (< 7.44.0)"); #endif } diff --git a/t/test-lib.sh b/t/test-lib.sh index 72604ec4fb2e53..8f92b8addc63b5 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -68,10 +68,15 @@ export PERL_PATH SHELL_PATH ################################################################ # It appears that people try to run tests without building... -test -n "$GIT_TEST_INSTALLED" || "$GIT_BUILD_DIR/git$X" >/dev/null || +"${GIT_TEST_INSTALLED:-$GIT_BUILD_DIR}/git$X" >/dev/null if test $? != 1 then - echo >&2 'error: you do not seem to have built git yet.' + if test -n "$GIT_TEST_INSTALLED" + then + echo >&2 "error: there is no working Git at '$GIT_TEST_INSTALLED'" + else + echo >&2 'error: you do not seem to have built git yet.' + fi exit 1 fi