book2: match ebook release assets by name, not content-type #1615
Conversation
Since progit2 2.1.309 switched to using a GitHub Action to generate
releases, it no longer sets the content-type field of the release
assets. And thus we fail to find any ebooks to link, since we are
looking for assets with "application/pdf", and so on.
Instead, let's do a suffix match against the name of each asset, looking
for the appropriate file extension. This works fine, since the names are
all obvious ("progit.epub", and so on). And it should be
backwards-compatible with older translations that haven't yet picked up
the new Actions-based workflow, since they used the same sensible names.
We may revert this later if the assets start generating with correct
content-types again. But it looks to be non-trivial (there's some
discussion in #1498), so this seems like a good solution in the
meantime.
I agree, this seems like a good fix for now. Will probably help the translations as well, as they will probably follow the main English repo with their CI setup, as they can basically copy/paste from the English repo and be done with their CI/releases. That content-type thing needs to be fixed with the upstream action that ProGit2 uses, or by ProGit2 using another action. I'm open for suggestion on a better action! 😉 |
|
I don't think the Travis CI is ever going to report back; it's still hooked to travis-ci.org, which shut down about 2 weeks ago. We probably should switch that out for an Action workflow. I'm going to merge this through in the meantime, since the ebook links are currently broken on the site. |
It's not going to report back, it's on permanent holiday. The poor CI bot is off on a vacation after being hammered with requests all the time. 😄 The ProGit2 Travis builds on |
Since progit2 2.1.309 switched to using a GitHub Action to generate releases, it no longer sets the content-type field of the release assets. And thus we fail to find any ebooks to link, since we are looking for assets with "application/pdf", and so on.
Instead, let's do a suffix match against the name of each asset, looking for the appropriate file extension. This works fine, since the names are all obvious ("progit.epub", and so on). And it should be backwards-compatible with older translations that haven't yet picked up the new Actions-based workflow, since they used the same sensible names.
We may revert this later if the assets start generating with correct content-types again. But it looks to be non-trivial (there's some discussion in #1498), so this seems like a good solution in the meantime.
/cc @HonkingGoose