update v2 book images from progit/progit2 #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is basically just a mass-import of every png in progit2's book/ directory, which appears to be what was done originally by @schacon when the book was initially imported. The main goal is to pick up any fixes (such as the one in progit/progit2#178), but it's hard to tell which images have changed content. In progit/progit2#424, all of the images were png-optimized, so just looking at the tree-diff doesn't say much. Literally every file image was touched there. Still, these are the images going into the current builds of the ebooks, so one assumes they are what we should be showing.
|
Poking through the progit2 history, looks like there have been a few other changes (like the renaming of a diagram), but they've all been picked up by other issues. So this should basically just be the fix for #771, and the png optimization. |
This was referenced Feb 10, 2017
Closed
peff
added a commit
that referenced
this pull request
Feb 10, 2017
We did this originally in #775, but the book hierarchy changed to a flat one since then. The new images are missing some updates and fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically just a mass-import of every png in progit2's book/ directory, which appears to be what was done originally by @schacon when the book was initially imported.
The main goal is to pick up any fixes (such as the one in progit/progit2#178), but it's hard to tell which images have changed content. In progit/progit2#424, all of the images were png-optimized, so just looking at the tree-diff doesn't say much. Literally every file image was touched there.
Still, these are the images going into the current builds of the ebooks, so one assumes they are what we should be showing.
Fixes #771.