Skip to content

Commit 1d8e31a

Browse files
derrickstoleegitster
authored andcommitted
revision: keep topo-walk free of unintersting commits
When updating the topo-order walk in b454241 (revision.c: generation-based topo-order algorithm, 2018-11-01), the logic was a huge rewrite of the walk logic. In that massive change, we accidentally included the UNINTERESTING commits in expand_topo_walk(). This means that a simple query like git rev-list --topo-order HEAD~1..HEAD will expand the topo walk for all commits reachable from HEAD, and not just one commit. This change should speed up these cases, but there is still a need for corrected commit-date for some A..B queries. Signed-off-by: Derrick Stolee <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 1b4d882 commit 1d8e31a

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

revision.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3265,6 +3265,9 @@ static void expand_topo_walk(struct rev_info *revs, struct commit *commit)
32653265
struct commit *parent = p->item;
32663266
int *pi;
32673267

3268+
if (parent->object.flags & UNINTERESTING)
3269+
continue;
3270+
32683271
if (parse_commit_gently(parent, 1) < 0)
32693272
continue;
32703273

0 commit comments

Comments
 (0)