Skip to content

Commit fa2c57d

Browse files
committed
Merge branch 'rs/commit-reach-leakfix'
Leakfix. * rs/commit-reach-leakfix: commit-reach: plug minor memory leak after using is_descendant_of()
2 parents b381c98 + d546fe2 commit fa2c57d

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

commit-reach.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,6 +411,7 @@ int ref_newer(const struct object_id *new_oid, const struct object_id *old_oid)
411411
struct object *o;
412412
struct commit *old_commit, *new_commit;
413413
struct commit_list *old_commit_list = NULL;
414+
int ret;
414415

415416
/*
416417
* Both new_commit and old_commit must be commit-ish and new_commit is descendant of
@@ -432,7 +433,9 @@ int ref_newer(const struct object_id *new_oid, const struct object_id *old_oid)
432433
return 0;
433434

434435
commit_list_insert(old_commit, &old_commit_list);
435-
return is_descendant_of(new_commit, old_commit_list);
436+
ret = is_descendant_of(new_commit, old_commit_list);
437+
free_commit_list(old_commit_list);
438+
return ret;
436439
}
437440

438441
/*

0 commit comments

Comments
 (0)