-
Notifications
You must be signed in to change notification settings - Fork 8
docs: add procedures for disabling loopback workaround #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Deployed on https://preview-153--hedgehog-docs.netlify.app |
Signed-off-by: Logan Blyth <[email protected]>
b0156ad
to
5fbae19
Compare
Signed-off-by: Logan Blyth <[email protected]>
Signed-off-by: Emanuele Di Pascale <[email protected]>
!!! note | ||
Starting from Fabric version 25.03, the loopback workaround is no longer needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then if it's no longer needed, why mention it at all in the docs and have this limitation listed?? Can't we just keep it in the stable branches of the docs? (We had this discussion for another limitation before.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because people might read the latest docs even when they are on old releases where the workaround was needed and/or enabled by default, and so it's better for them to have this information here too (imho)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an addendum, when we no longer support versions of the fabric where these limitation applied, then I would be totally in favor of removing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because people might read the latest docs even when they are on old releases where the workaround was needed and/or enabled by default
If they run old releases they should read the docs for the old release 🤷 and the old release should list the workarounds to use. It seems confusing to me to keep limitations in the docs that no longer apply.
when we no longer support versions of the fabric where these limitation applied, then I would be totally in favor of removing it
Yes please, or we'll end up with notes for all limitations removed since the early days of the project 🫠
closes #141