Skip to content

docs: add procedures for disabling loopback workaround #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2025

Conversation

mrbojangles3
Copy link
Contributor

closes #141

Copy link

github-actions bot commented Jul 1, 2025

🚀 Deployed on https://preview-153--hedgehog-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 1, 2025 04:17 Inactive
@mrbojangles3 mrbojangles3 marked this pull request as ready for review July 1, 2025 04:17
@mrbojangles3 mrbojangles3 requested a review from a team as a code owner July 1, 2025 04:17
@mrbojangles3 mrbojangles3 force-pushed the disable_loopback_workaround branch from b0156ad to 5fbae19 Compare July 1, 2025 05:14
@mrbojangles3 mrbojangles3 requested a review from Frostman July 1, 2025 05:14
@github-actions github-actions bot temporarily deployed to pull request July 1, 2025 05:15 Inactive
Signed-off-by: Logan Blyth <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request July 1, 2025 14:05 Inactive
edipascale
edipascale previously approved these changes Jul 1, 2025
@github-actions github-actions bot temporarily deployed to pull request July 1, 2025 14:45 Inactive
@Frostman Frostman merged commit 580c74a into master Jul 1, 2025
4 checks passed
@Frostman Frostman deleted the disable_loopback_workaround branch July 1, 2025 14:59
Comment on lines +67 to +68
!!! note
Starting from Fabric version 25.03, the loopback workaround is no longer needed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then if it's no longer needed, why mention it at all in the docs and have this limitation listed?? Can't we just keep it in the stable branches of the docs? (We had this discussion for another limitation before.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because people might read the latest docs even when they are on old releases where the workaround was needed and/or enabled by default, and so it's better for them to have this information here too (imho)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an addendum, when we no longer support versions of the fabric where these limitation applied, then I would be totally in favor of removing it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because people might read the latest docs even when they are on old releases where the workaround was needed and/or enabled by default

If they run old releases they should read the docs for the old release 🤷 and the old release should list the workarounds to use. It seems confusing to me to keep limitations in the docs that no longer apply.

when we no longer support versions of the fabric where these limitation applied, then I would be totally in favor of removing it

Yes please, or we'll end up with notes for all limitations removed since the early days of the project 🫠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document disabling loopback workaround on BCM 4.5.0
5 participants