runner-binaries-syncer : "source_hash" is not expected here

[AliAllomani]

"aws_s3_bucket_object" "trigger" : etag was replaced with source_hash in #1783.

However, terraform provider version is still locked to v3.38 which doesn't have source_hash parameter for aws_s3_bucket_object

https://github.com/philips-labs/terraform-aws-github-runner/blob/e3e63367178eb0c65062268555c04ad1f6fb0f83/modules/runner-binaries-syncer/versions.tf#L4-L8

https://registry.terraform.io/providers/hashicorp/aws/3.38.0/docs/resources/s3_bucket_object

│ Error: Unsupported argument
│ 
│   on .terraform/modules/runners/modules/runner-binaries-syncer/runner-binaries-syncer.tf line 126, in resource "aws_s3_bucket_object" "trigger":
│  126:   source_hash = filemd5("${path.module}/trigger.json")
│ 
│ An argument named "source_hash" is not expected here.

[npalm]

@AliAllomani thanks for pointing out this issue. We planning to upgrade the module to the AWS provider 4.x soon. In the mean time I will upgrade the minimal provider version.

ref: release 3.50 introduced the option: https://github.com/hashicorp/terraform-provider-aws/releases/tag/v3.50.0

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.