Skip to content

Wrong settings section description in **Code security** docs #35324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
akordowski opened this issue Nov 18, 2024 · 7 comments
Closed
1 task done

Wrong settings section description in **Code security** docs #35324

akordowski opened this issue Nov 18, 2024 · 7 comments
Labels
code security Content related to code security content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Comments

@akordowski
Copy link
Contributor

akordowski commented Nov 18, 2024

Code of Conduct

What article on docs.github.com is affected?

What part(s) of the article would you like to see updated?

Article Enabling Dependabot for your repository

The article describes the Settings / Security / Code security and analysis section:

grafik

Article Managing the dependency graph

The article describes the Security & analysis section:

grafik

But in GitHub Settings the section is just named Code security:

grafik

EDIT:
There a actually muliple occurrences of the described issues in the docs.

Additional information

I could provide a PR to fix this issues.

@akordowski akordowski added the content This issue or pull request belongs to the Docs Content team label Nov 18, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 18, 2024
@nguyenalex836 nguyenalex836 added waiting for review Issue/PR is waiting for a writer's review code security Content related to code security and removed triage Do not begin working on this issue until triaged by the team labels Nov 18, 2024
@nguyenalex836
Copy link
Contributor

@akordowski Thank you for raising this issue! I'll get this triaged for review ✨ Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

@subatoi
Copy link
Contributor

subatoi commented Nov 19, 2024

Hi again @akordowski 👋

Unfortunately, for this one, it's complicated by the fact that for different GHES versions, the text varies. We have some work scheduled to fix the documentation internally. You are however quite correct that the current documentation on this has mistakes.

I won't close this yet, but I wanted to set expectations appropriately before you went ahead and raised a PR, as the likelihood is that we won't be able to open this up to contributors.

@akordowski
Copy link
Contributor Author

@subatoi Thanks for the info! Feel free to let me know if I can help any how.

@akordowski
Copy link
Contributor Author

@subatoi As this issue will be done by the team I close this issue.

@subatoi
Copy link
Contributor

subatoi commented Nov 28, 2024

Thank you!

@subatoi
Copy link
Contributor

subatoi commented Dec 4, 2024

@akordowski For the issues concerning this naming error, I just wanted to let you know that I'll be shipping fixes shortly

I tried to add you as co-committer but it didn't work—apologies about that (I'll investigate why but I think it may have been a transient availability issue). Please rest assured we really appreciate your contributions!

@akordowski
Copy link
Contributor Author

I tried to add you as co-committer but it didn't work

@subatoi No worries, I provided so many PRs so its fine with me 😆
Thank you for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code security Content related to code security content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

No branches or pull requests

3 participants