Improve test

Author: timvaillancourt

go/logic/hooks_test.go

@@ -11,8 +11,10 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
+	"strconv"
 	"strings"
 	"testing"
+	"time"
 
 	"github.com/openark/golib/tests"
 
@@ -23,15 +25,21 @@ func TestHooksExecutorExecuteHooks(t *testing.T) {
 	migrationContext := base.NewMigrationContext()
 	migrationContext.AlterStatement = "ENGINE=InnoDB"
 	migrationContext.DatabaseName = "test"
+	migrationContext.Hostname = "test.example.com"
 	migrationContext.OriginalTableName = "tablename"
+	migrationContext.RowsDeltaEstimate = 1
+	migrationContext.RowsEstimate = 122
+	migrationContext.TotalRowsCopied = 123456
+	migrationContext.SetETADuration(time.Minute)
+	migrationContext.SetProgressPct(50)
 	hooksExecutor := NewHooksExecutor(migrationContext)
 
-	writeTmpHookFunc := func(testName, hookName, script string) (hooksPath string, err error) {
-		if hooksPath, err = os.MkdirTemp("", testName); err != nil {
-			return hooksPath, err
+	writeTmpHookFunc := func(testName, hookName, script string) (path string, err error) {
+		if path, err = os.MkdirTemp("", testName); err != nil {
+			return path, err
 		}
-		err = os.WriteFile(filepath.Join(hooksPath, hookName), []byte(script), 0777)
-		return hooksPath, err
+		err = os.WriteFile(filepath.Join(path, hookName), []byte(script), 0777)
+		return path, err
 	}
 
 	t.Run("does-not-exist", func(t *testing.T) {
@@ -71,14 +79,30 @@ func TestHooksExecutorExecuteHooks(t *testing.T) {
 		for scanner.Scan() {
 			split := strings.SplitN(scanner.Text(), "=", 2)
 			switch split[0] {
+			case "GH_OST_COPIED_ROWS":
+				copiedRows, _ := strconv.ParseInt(split[1], 10, 64)
+				tests.S(t).ExpectEquals(copiedRows, migrationContext.TotalRowsCopied)
 			case "GH_OST_DATABASE_NAME":
 				tests.S(t).ExpectEquals(split[1], migrationContext.DatabaseName)
 			case "GH_OST_DDL":
 				tests.S(t).ExpectEquals(split[1], migrationContext.AlterStatement)
+			case "GH_OST_DRY_RUN":
+				tests.S(t).ExpectEquals(split[1], "false")
+			case "GH_OST_ESTIMATED_ROWS":
+				estimatedRows, _ := strconv.ParseInt(split[1], 10, 64)
+				tests.S(t).ExpectEquals(estimatedRows, int64(123))
+			case "GH_OST_ETA_SECONDS":
+				etaSeconds, _ := strconv.ParseInt(split[1], 10, 64)
+				tests.S(t).ExpectEquals(etaSeconds, int64(60))
+			case "GH_OST_EXECUTING_HOST":
+				tests.S(t).ExpectEquals(split[1], migrationContext.Hostname)
 			case "GH_OST_GHOST_TABLE_NAME":
 				tests.S(t).ExpectEquals(split[1], fmt.Sprintf("_%s_gho", migrationContext.OriginalTableName))
 			case "GH_OST_OLD_TABLE_NAME":
 				tests.S(t).ExpectEquals(split[1], fmt.Sprintf("_%s_del", migrationContext.OriginalTableName))
+			case "GH_OST_PROGRESS":
+				progress, _ := strconv.ParseFloat(split[1], 64)
+				tests.S(t).ExpectEquals(progress, 50.0)
 			case "GH_OST_TABLE_NAME":
 				tests.S(t).ExpectEquals(split[1], migrationContext.OriginalTableName)
 			case "TEST":