Merge pull request #1140 from timvaillancourt/fix-issue-1117

dm-2 · web-flow · commit 3901a864221e · 2022-07-06T17:11:16.000+01:00
Fix `integer divide by zero` panic in migrator
diff --git a/go/logic/migrator.go b/go/logic/migrator.go
@@ -1009,7 +1009,8 @@ func (this *Migrator) printStatus(rule PrintStatusRule, writers ...io.Writer) {
 	w := io.MultiWriter(writers...)
 	fmt.Fprintln(w, status)
 
-	if elapsedSeconds%this.migrationContext.HooksStatusIntervalSec == 0 {
+	hooksStatusIntervalSec := this.migrationContext.HooksStatusIntervalSec
+	if hooksStatusIntervalSec > 0 && elapsedSeconds%hooksStatusIntervalSec == 0 {
 		this.hooksExecutor.onStatus(status)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -1009,7 +1009,8 @@ func (this *Migrator) printStatus(rule PrintStatusRule, writers ...io.Writer) {`
`1009`	`1009`	`w := io.MultiWriter(writers...)`
`1010`	`1010`	`fmt.Fprintln(w, status)`
`1011`	`1011`
`1012`		`- if elapsedSeconds%this.migrationContext.HooksStatusIntervalSec == 0 {`
	`1012`	`+ hooksStatusIntervalSec := this.migrationContext.HooksStatusIntervalSec`
	`1013`	`+ if hooksStatusIntervalSec > 0 && elapsedSeconds%hooksStatusIntervalSec == 0 {`
`1013`	`1014`	`this.hooksExecutor.onStatus(status)`
`1014`	`1015`	`}`
`1015`	`1016`	`}`