change []string to []error as its not needed

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>

Author: Pothulapati

plugins/deployed-labeler/main.go

@@ -107,45 +107,32 @@ func (s *server) markDeployedPR(w http.ResponseWriter, req *http.Request) {
 
 	if team == "" || commitSHA == "" {
 
-		var preconditionFailed struct {
-			Errors []string
-		}
-
-		preconditionFailed.Errors = make([]string, 0, 1)
-		preconditionFailed.Errors = append(preconditionFailed.Errors, fmt.Sprintf("team and commit are required parameters. Team: '%v', commit: '%v'", team, commitSHA))
-
 		s.log.WithFields(
 			logrus.Fields{
 				"team":   team,
 				"commit": commitSHA,
 			},
 		).Error("team and commit are required parameters")
 
-		w.Header().Set("Content-Type", "application/json; charset=utf-8")
-		w.Header().Set("X-Content-Type-Options", "nosniff")
 		w.WriteHeader(http.StatusPreconditionFailed)
-		json.NewEncoder(w).Encode(preconditionFailed)
+		enc := json.NewEncoder(w)
+		enc.SetIndent("", "  ")
+		enc.Encode(map[string]string{
+			"error": "team and commit are required parameters",
+		})
 		return
 	}
 
-	var errs []error
-
 	switch req.Method {
-	case "GET":
+	case "POST":
 		var msg struct {
-			PRs struct {
-				Labeled   []string `json:"labeled"`
-				Unlabeled []string `json:"unlabeled"`
-			}
-			Errors []string `json:"errors"`
-		}
-
-		msg.PRs.Labeled, msg.PRs.Unlabeled, errs = s.handleGetUnmarkedPRs(req.Context(), commitSHA, team)
-
-		msg.Errors = make([]string, 0, len(errs))
-		for _, err := range errs {
-			msg.Errors = append(msg.Errors, err.Error())
+			DeployedPRs struct {
+				Team []string `json:"team"`
+				All  []string `json:"all"`
+			} `json:"deployedPRs"`
+			Errors []error `json:"errors"`
 		}
+		msg.DeployedPRs.Team, msg.DeployedPRs.All, msg.Errors = s.handleMarkDeployedPRs(req.Context(), commitSHA, team)
 
 		if len(msg.Errors) > 0 {
 			w.WriteHeader(http.StatusUnprocessableEntity)
@@ -154,21 +141,16 @@ func (s *server) markDeployedPR(w http.ResponseWriter, req *http.Request) {
 		enc := json.NewEncoder(w)
 		enc.SetIndent("", "  ")
 		enc.Encode(msg)
-
-	case "POST":
+	case "GET":
 		var msg struct {
-			DeployedPRs struct {
-				Team []string `json:"team"`
-				All  []string `json:"all"`
-			} `json:"deployedPRs"`
+			PRs struct {
+				Labeled   []string `json:"labeled"`
+				Unlabeled []string `json:"unlabeled"`
+			}
 			Errors []error `json:"errors"`
 		}
-		msg.DeployedPRs.Team, msg.DeployedPRs.All, msg.Errors = s.handleMarkDeployedPRs(req.Context(), commitSHA, team)
 
-		msg.Errors = make([]string, 0, len(errs))
-		for _, err := range errs {
-			msg.Errors = append(msg.Errors, err.Error())
-		}
+		msg.PRs.Labeled, msg.PRs.Unlabeled, msg.Errors = s.handleGetUnmarkedPRs(req.Context(), commitSHA, team)
 
 		if len(msg.Errors) > 0 {
 			w.WriteHeader(http.StatusUnprocessableEntity)
@@ -177,6 +159,7 @@ func (s *server) markDeployedPR(w http.ResponseWriter, req *http.Request) {
 		enc := json.NewEncoder(w)
 		enc.SetIndent("", "  ")
 		enc.Encode(msg)
+
 	default:
 		w.WriteHeader(http.StatusNotImplemented)
 		w.Write([]byte(http.StatusText(http.StatusNotImplemented)))