Skip to content

Commit 1646d5c

Browse files
committed
[ws-daemon] Force fuse fsshift for FWB
1 parent 9d4f213 commit 1646d5c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.werft/values.dev.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,9 @@ components:
131131
- mountPath: /mnt/sync-tmp
132132
name: gcloud-tmp
133133
userNamespaces:
134-
fsShift: fuse
134+
fsShift: shiftfs
135135
shiftfsModuleLoader:
136-
enabled: false
136+
enabled: true
137137
seccompProfileInstaller:
138138
enabled: true
139139

components/ws-daemon/pkg/iws/iws.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ func (wbs *InWorkspaceServiceServer) PrepareForUserNS(ctx context.Context, req *
236236

237237
mountpoint := filepath.Join(wbs.Session.ServiceLocNode, "mark")
238238

239-
if wbs.FSShift == api.FSShiftMethod_FUSE {
239+
if wbs.FSShift == api.FSShiftMethod_FUSE || wbs.Session.FullWorkspaceBackup {
240240
err = nsinsider(wbs.Session.InstanceID, int(1), func(c *exec.Cmd) {
241241
// In case of any change in the user mapping, the next line must be updated.
242242
mappings := fmt.Sprintf("0:%v:1:1:100000:65534", wsinit.GitpodUID)
@@ -253,6 +253,7 @@ func (wbs *InWorkspaceServiceServer) PrepareForUserNS(ctx context.Context, req *
253253
return nil, status.Errorf(codes.Internal, "cannot mount fusefs mark")
254254
}
255255

256+
log.WithFields(wbs.Session.OWI()).WithField("configuredShift", wbs.FSShift).WithField("fwb", wbs.Session.FullWorkspaceBackup).Info("fs-shift using fuse")
256257
return &api.PrepareForUserNSResponse{
257258
FsShift: api.FSShiftMethod_FUSE,
258259
FullWorkspaceBackup: wbs.Session.FullWorkspaceBackup,

0 commit comments

Comments
 (0)