[analytics] Fix segment assertion error

Author: geropl

components/gitpod-protocol/src/util/analytics.ts

@@ -58,11 +58,15 @@ class SegmentAnalyticsWriter implements IAnalyticsWriter {
     }
 
     identify(msg: IdentifyMessage) {
-        this.analytics.identify(msg);
+        this.analytics.identify(msg, (err: Error) => {
+            log.warn("analytics.identify failed", err, msg);
+        });
     }
 
     track(msg: TrackMessage) {
-        this.analytics.track(msg);
+        this.analytics.track(msg, (err: Error) => {
+            log.warn("analytics.track failed", err, msg);
+        });
     }
 
 }

components/server/src/workspace/gitpod-server-impl.ts

@@ -1314,6 +1314,7 @@ export class GitpodServerImpl<Client extends GitpodClient, Server extends Gitpod
     async setEnvVar(variable: UserEnvVarValue): Promise<void> {
         // Note: this operation is per-user only, hence needs no resource guard
         const user = this.checkUser("setEnvVar");
+        const userId = user.id;
 
         variable.repositoryPattern = UserEnvVar.normalizeRepoPattern(variable.repositoryPattern);
         const existingVars = (await this.userDB.getEnvVars(user.id)).filter(v => !v.deleted);
@@ -1335,17 +1336,18 @@ export class GitpodServerImpl<Client extends GitpodClient, Server extends Gitpod
         const envvar: UserEnvVar = {
             ...variable,
             id: variable.id || uuidv4(),
-            userId: user.id,
+            userId,
         };
         await this.guardAccess({ kind: 'envVar', subject: envvar }, typeof variable.id === 'string' ? 'update' : 'create');
-        this.analytics.track({ event: "envvar-set", userId: this.user?.id || "" });
+        this.analytics.track({ event: "envvar-set", userId });
 
         await this.userDB.setEnvVar(envvar);
     }
 
     async deleteEnvVar(variable: UserEnvVarValue): Promise<void> {
         // Note: this operation is per-user only, hence needs no resource guard
         const user = this.checkUser("deleteEnvVar");
+        const userId = user.id;
 
         if (!variable.id && variable.name && variable.repositoryPattern) {
             variable.repositoryPattern = UserEnvVar.normalizeRepoPattern(variable.repositoryPattern);
@@ -1361,10 +1363,10 @@ export class GitpodServerImpl<Client extends GitpodClient, Server extends Gitpod
         const envvar: UserEnvVar = {
             ...variable,
             id: variable.id!,
-            userId: user.id,
+            userId,
         };
         await this.guardAccess({ kind: 'envVar', subject: envvar }, 'delete');
-        this.analytics.track({ event: "envvar-deleted", userId: this.user?.id || "" });
+        this.analytics.track({ event: "envvar-deleted", userId });
 
         await this.userDB.deleteEnvVar(envvar);
     }

components/ws-manager-bridge/src/bridge.ts

@@ -208,7 +208,7 @@ export class WorkspaceManagerBridge implements Disposable {
                             event: "workspace-running",
                             messageId: `bridge-wsrun-${instance.id}`,
                             properties: { instanceId: instance.id, workspaceId: workspaceId },
-                            anonymousId: ""
+                            userId,
                         });
                     }