Skip to content

Commit 44ef470

Browse files
aledbfroboquat
authored andcommitted
Remove unused labels
1 parent 3063396 commit 44ef470

File tree

3 files changed

+2
-14
lines changed

3 files changed

+2
-14
lines changed

components/common-go/kubernetes/kubernetes.go

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,21 +37,12 @@ const (
3737
// ServiceTypeLabel help differentiate between port service and IDE service
3838
ServiceTypeLabel = "serviceType"
3939

40-
// GitpodDiskPressureLabel marks a node as having disk pressure (besides the root disk - used for the workspace SSDs, set by ws-daemon)
41-
GitpodDiskPressureLabel = "gitpod.io/diskPressure"
42-
43-
// GitpodNodeServiceLabel marks a pod as providing a particular service to a node
44-
GitpodNodeServiceLabel = "gitpod.io/nodeService"
45-
4640
// TraceIDAnnotation adds a Jaeger/OpenTracing header to the pod so that we can trace it's behaviour
4741
TraceIDAnnotation = "gitpod/traceid"
4842

4943
// CPULimitAnnotation enforces a strict CPU limit on a workspace by virtue of ws-daemon
5044
CPULimitAnnotation = "gitpod.io/cpuLimit"
5145

52-
// RequiredNodeServicesAnnotation lists all Gitpod services required on the node
53-
RequiredNodeServicesAnnotation = "gitpod.io/requiredNodeServices"
54-
5546
// ContainerIsGoneAnnotation is used as workaround for containerd https://github.com/containerd/containerd/pull/4214
5647
// which might cause workspace container status propagation to fail, which in turn would keep a workspace running indefinitely.
5748
ContainerIsGoneAnnotation = "gitpod.io/containerIsGone"

components/ws-manager/pkg/manager/create.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,6 @@ func (m *Manager) createDefiniteWorkspacePod(startContext *startWorkspaceContext
305305
kubernetes.WorkspaceImageSpecAnnotation: imageSpec,
306306
kubernetes.OwnerTokenAnnotation: startContext.OwnerToken,
307307
wsk8s.TraceIDAnnotation: startContext.TraceID,
308-
wsk8s.RequiredNodeServicesAnnotation: "ws-daemon,registry-facade",
309308
// TODO(cw): post Kubernetes 1.19 use GA form for settings those profiles
310309
"container.apparmor.security.beta.kubernetes.io/workspace": "unconfined",
311310
// We're using a custom seccomp profile for user namespaces to allow clone, mount and chroot.

install/installer/pkg/common/common.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import (
1313
"strconv"
1414
"strings"
1515

16-
wsk8s "github.com/gitpod-io/gitpod/common-go/kubernetes"
1716
config "github.com/gitpod-io/gitpod/installer/pkg/config/v1"
1817
"github.com/gitpod-io/gitpod/installer/pkg/config/v1/experimental"
1918

@@ -31,9 +30,8 @@ import (
3130

3231
func DefaultLabels(component string) map[string]string {
3332
return map[string]string{
34-
"app": AppName,
35-
"component": component,
36-
wsk8s.GitpodNodeServiceLabel: component,
33+
"app": AppName,
34+
"component": component,
3735
}
3836
}
3937

0 commit comments

Comments
 (0)