Skip to content

Commit 4c2802c

Browse files
committed
Use 9500 in line with other services
1 parent d80abc4 commit 4c2802c

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

components/common-go/baseserver/options.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ func defaultConfig() *config {
3636
return &config{
3737
logger: log.New(),
3838
hostname: "localhost",
39-
httpPort: 9000,
40-
grpcPort: 9001,
39+
httpPort: 9500,
40+
grpcPort: 9501,
4141
closeTimeout: 5 * time.Second,
4242
healthHandler: healthcheck.NewHandler(),
4343
}

components/common-go/baseserver/options_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,11 @@ func TestOptions(t *testing.T) {
4545
}, cfg)
4646
}
4747

48+
func TestDefaultOptions_Ports(t *testing.T) {
49+
require.Equal(t, 9500, defaultConfig().httpPort)
50+
require.Equal(t, 9501, defaultConfig().grpcPort)
51+
}
52+
4853
func TestWithTTPPort(t *testing.T) {
4954
t.Run("negative", func(t *testing.T) {
5055
_, err := evaluateOptions(defaultConfig(), WithHTTPPort(-1))

install/installer/pkg/common/common.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ func KubeRBACProxyContainer(ctx *RenderContext) *corev1.Container {
287287
"--v=5",
288288
"--logtostderr",
289289
"--insecure-listen-address=[$(IP)]:9500",
290-
"--upstream=http://127.0.0.1:9500/",
290+
"--upstream=http://127.0.0.1:Is there a reason this PR still has it? Would it make sense to add sth akin \"make sure to remove the label before marking a PR as \"review ready\"\" to our \"how we work\"? 🤔/",
291291
},
292292
Ports: []corev1.ContainerPort{
293293
{Name: "metrics", ContainerPort: 9500},

install/installer/pkg/components/public-api-server/constants.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ const (
88
Component = "public-api-server"
99

1010
HTTPPortName = "http"
11-
HTTPContainerPort = 9000
11+
HTTPContainerPort = 9500
1212
HTTPServicePort = 9000
1313

1414
GRPCPortName = "grpc"
15-
GRPCContainerPort = 9001
15+
GRPCContainerPort = 9501
1616
GRPCServicePort = 9001
1717
)

0 commit comments

Comments
 (0)