Skip to content

Commit 4e2c57e

Browse files
jeanp413roboquat
authored andcommitted
Use space character instead of u+00a0
1 parent 4a907f9 commit 4e2c57e

13 files changed

+29
-29
lines changed

CHANGELOG.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@
327327
- [ws-daemon] Remove gitpod_ws_daemon_workspace_cpu_limit_sec metric ([#5444](https://github.com/gitpod-io/gitpod/pull/5444)) - [@aledbf](https://github.com/aledbf)
328328
- Upgrade grpc-js library ([#5455](https://github.com/gitpod-io/gitpod/pull/5455)) - [@meysholdt](https://github.com/meysholdt), [@princerachit](https://github.com/princerachit)
329329
- [ws-manager] Restart pod on config change ([#5454](https://github.com/gitpod-io/gitpod/pull/5454)) - [@geropl](https://github.com/geropl)
330-
- [local-app] gracefully handle invalid token ([#5369](https://github.com/gitpod-io/gitpod/pull/5369)) - [@akosyakov](https://github.com/akosyakov)
330+
- [local-app] gracefully handle invalid token ([#5369](https://github.com/gitpod-io/gitpod/pull/5369)) - [@akosyakov](https://github.com/akosyakov)
331331
- [helm] Add liveness probe to ws-proxy deployment ([#5286](https://github.com/gitpod-io/gitpod/pull/5286)) - [@princerachit](https://github.com/princerachit)
332332
- changed nodeAffinity for preview environments ([#5432](https://github.com/gitpod-io/gitpod/pull/5432)) - [@wulfthimm](https://github.com/wulfthimm)
333333
- [license] adjust users of self-hosted license ([#5420](https://github.com/gitpod-io/gitpod/pull/5420)) - [@laushinka](https://github.com/laushinka)
@@ -348,7 +348,7 @@
348348
- [workspacekit] Establish IWS conn for proc mounts ([#5407](https://github.com/gitpod-io/gitpod/pull/5407)) - [@csweichel](https://github.com/csweichel)
349349
- [ws-manager] Properly stop workspaces that never make it to the RUNNING phase ([#5396](https://github.com/gitpod-io/gitpod/pull/5396)) - [@csweichel](https://github.com/csweichel)
350350
- [caddy] reroute legacy URIs ([#5393](https://github.com/gitpod-io/gitpod/pull/5393)) - [@JanKoehnlein](https://github.com/JanKoehnlein)
351-
- [code] improve share workspace notification ([#5384](https://github.com/gitpod-io/gitpod/pull/5384)) - [@jeanp413](https://github.com/jeanp413)
351+
- [code] improve share workspace notification ([#5384](https://github.com/gitpod-io/gitpod/pull/5384)) - [@jeanp413](https://github.com/jeanp413)
352352
- [dashboard] Allow onboarding mail ([#5397](https://github.com/gitpod-io/gitpod/pull/5397)) - [@laushinka](https://github.com/laushinka)
353353
- [code] rename gitpod extensions ([#5353](https://github.com/gitpod-io/gitpod/pull/5353)) - [@akosyakov](https://github.com/akosyakov)
354354
- [dashboard] De-noise backend error messages in Project Configurator ([#5395](https://github.com/gitpod-io/gitpod/pull/5395)) - [@jankeromnes](https://github.com/jankeromnes)
@@ -380,7 +380,7 @@
380380
- [dashboard] Update tailwindcss and enable jit (now stable) ([#4655](https://github.com/gitpod-io/gitpod/pull/4655)) - [@aledbf](https://github.com/aledbf)
381381
- [ws-daemon] remove failed backups ([#5325](https://github.com/gitpod-io/gitpod/pull/5325)) - [@svenefftinge](https://github.com/svenefftinge)
382382
- [workspace]: update logs ([#5257](https://github.com/gitpod-io/gitpod/pull/5257)) - [@MrSimonEmms](https://github.com/MrSimonEmms)
383-
- [code] smooth VS Code desktop flow ([#5287](https://github.com/gitpod-io/gitpod/pull/5287)) - [@akosyakov](https://github.com/akosyakov)
383+
- [code] smooth VS Code desktop flow ([#5287](https://github.com/gitpod-io/gitpod/pull/5287)) - [@akosyakov](https://github.com/akosyakov)
384384
- [workspacekit] Close lift unix socket on termination ([#5296](https://github.com/gitpod-io/gitpod/pull/5296)) - [@aledbf](https://github.com/aledbf)
385385
- [ws-manager] Ensure status before setting phase tag ([#5294](https://github.com/gitpod-io/gitpod/pull/5294)) - [@aledbf](https://github.com/aledbf)
386386
- Update long description in messagebus ([#5291](https://github.com/gitpod-io/gitpod/pull/5291)) - [@YauhenPylAurea](https://github.com/YauhenPylAurea)
@@ -537,7 +537,7 @@
537537
- [content-service] Improve CPU utilization for initial git clone command ([#4847](https://github.com/gitpod-io/gitpod/pull/4847)) - [@aledbf](https://github.com/aledbf)
538538
- [server] Handle `releases/tag/<tag>` in GitHub context parser ([#4813](https://github.com/gitpod-io/gitpod/pull/4813)) - [@corneliusludmann](https://github.com/corneliusludmann)
539539
- [ws-manager] Pull images if not present ([#4837](https://github.com/gitpod-io/gitpod/pull/4837)) - [@csweichel](https://github.com/csweichel)
540-
- [code] serve each webview from own origin ([#4738](https://github.com/gitpod-io/gitpod/pull/4738)) - [@akosyakov](https://github.com/akosyakov)
540+
- [code] serve each webview from own origin ([#4738](https://github.com/gitpod-io/gitpod/pull/4738)) - [@akosyakov](https://github.com/akosyakov)
541541
- [.gitpod.yml] update config ([#4798](https://github.com/gitpod-io/gitpod/pull/4798)) - [@svenefftinge](https://github.com/svenefftinge)
542542
- [server] Set owner token cookie HttpOnly and Secure ([#4832](https://github.com/gitpod-io/gitpod/pull/4832)) - [@csweichel](https://github.com/csweichel)
543543
- [gp] env: handle multi-word values without quotes ([#4816](https://github.com/gitpod-io/gitpod/pull/4816)) - [@geropl](https://github.com/geropl)
@@ -566,7 +566,7 @@
566566
- [server] Improve logging / error messages of GitLab app and context parser ([#4747](https://github.com/gitpod-io/gitpod/pull/4747)) - [@corneliusludmann](https://github.com/corneliusludmann)
567567
- [admin] Fix adminRestoreSoftDeletedWorkspace ([#4772](https://github.com/gitpod-io/gitpod/pull/4772)) - [@corneliusludmann](https://github.com/corneliusludmann)
568568
- [bpf] Reduce QEMU disk size ([#4766](https://github.com/gitpod-io/gitpod/pull/4766)) - [@geropl](https://github.com/geropl)
569-
- [code] confirm sharing ([#4743](https://github.com/gitpod-io/gitpod/pull/4743)) - [@akosyakov](https://github.com/akosyakov)
569+
- [code] confirm sharing ([#4743](https://github.com/gitpod-io/gitpod/pull/4743)) - [@akosyakov](https://github.com/akosyakov)
570570
- [ws-daemon] cgroup customizer on workspace add (fuse support) ([#4762](https://github.com/gitpod-io/gitpod/pull/4762)) - [@fntlnz](https://github.com/fntlnz)
571571
- [werft] K3s ws cluster register wait on dependent pods ([#4748](https://github.com/gitpod-io/gitpod/pull/4748)) - [@princerachit](https://github.com/princerachit)
572572
- [dashboard] Make sure the error thrown from getLoggedInUser takes pre… ([#4764](https://github.com/gitpod-io/gitpod/pull/4764)) - [@geropl](https://github.com/geropl)
@@ -595,13 +595,13 @@
595595
## June 2021
596596

597597
- Complete validations of VS Code extensions in .gitpod.yml ([#4645](https://github.com/gitpod-io/gitpod/pull/4645)):
598-
| Check | Quick Fixes |
598+
| Check | Quick Fixes |
599599
| --- | --- |
600-
| Deprecated user uploaded extensions | Resolve them against Open VSX |
601-
| Extensions cannot be found in Open VSX | Remove from .gitpod.yml or search for them in Open VSX |
602-
| Extensions URLs cannot be resolved to valid VSIX files | Remove from .gitpod.yml |
603-
| Extensions is installed for the workspace but missing in .gitpod.yml | Add to .gitpod.yml or uninstall |
604-
| Extensions is uninstalled but present in .gitpod.yml | Remove from .gitpod.yml or install as no synced |
600+
| Deprecated user uploaded extensions | Resolve them against Open VSX |
601+
| Extensions cannot be found in Open VSX | Remove from .gitpod.yml or search for them in Open VSX |
602+
| Extensions URLs cannot be resolved to valid VSIX files | Remove from .gitpod.yml |
603+
| Extensions is installed for the workspace but missing in .gitpod.yml | Add to .gitpod.yml or uninstall |
604+
| Extensions is uninstalled but present in .gitpod.yml | Remove from .gitpod.yml or install as no synced |
605605
- Breaking Change: Make ports configured in `.gitpod.yml` private by default when no value for `visibility` is given (was public). This change is for security reasons. ([#4548](https://github.com/gitpod-io/gitpod/pull/4548))
606606
- Added a deprecation warning for Theia ([#4614](https://github.com/gitpod-io/gitpod/pull/4614))
607607
- Deprecate `prebuild` task in `gitpod.yml` ([#4543](https://github.com/gitpod-io/gitpod/pull/4543))

License.third-party.npm.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24094,7 +24094,7 @@ The following software may be included in this product: selfsigned. A copy of th
2409424094

2409524095
MIT License
2409624096

24097-
Copyright (c) 2013 José F. Romaniello
24097+
Copyright (c) 2013 José F. Romaniello
2409824098

2409924099
Permission is hereby granted, free of charge, to any person obtaining a copy
2410024100
of this software and associated documentation files (the "Software"), to deal

components/dashboard/src/components/ConfirmationModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export default function ConfirmationModal(props: {
6464
visible={props.visible === undefined ? true : props.visible}
6565
onClose={props.onClose}
6666
onEnter={() => {
67-
if (cancelButtonRef?.current?.contains(document.activeElement)) {
67+
if (cancelButtonRef?.current?.contains(document.activeElement)) {
6868
props.onClose();
6969
return false;
7070
}

components/ee/payment-endpoint/src/accounting/account-service.spec.db.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ const end = new Date(Date.UTC(2000, 2, 1)).toISOString();
194194
expect(statement!.remainingHours).to.be.equal(800);
195195
}
196196

197-
@test async noSessions() {
197+
@test async noSessions() {
198198
expect(await this.invoice(start)).to.be.equal('')
199199
expect(await this.invoice(rightAfter(start))).to.be.equal('2000-01-01T00:00:00.000Z 100 credit 100')
200200
expect(await this.invoice(rightBefore(secondMonth))).to.be.equal('2000-01-01T00:00:00.000Z 100 credit 100');
@@ -388,7 +388,7 @@ const end = new Date(Date.UTC(2000, 2, 1)).toISOString();
388388
2000-02-29T23:59:59.999Z -100 expiry`);
389389
}
390390

391-
@test async multiSubscription() {
391+
@test async multiSubscription() {
392392
const subscriptionSwitchDate = hoursLater(start, 10 * 24); // 10 days
393393
Subscription.cancelSubscription(this.subscription, subscriptionSwitchDate, oneMonthLater(this.subscription.startDate));
394394
await this.accountingDb.storeSubscription(this.subscription);
@@ -406,7 +406,7 @@ const end = new Date(Date.UTC(2000, 2, 1)).toISOString();
406406
2000-02-11T00:00:00.000Z 200 credit 200`);
407407
}
408408

409-
@test async multiSubscriptionOverlappingSession() {
409+
@test async multiSubscriptionOverlappingSession() {
410410
const subscriptionSwitchDate = hoursLater(start, 240);
411411
Subscription.cancelSubscription(this.subscription, subscriptionSwitchDate, oneMonthLater(this.subscription.startDate));
412412
await this.accountingDb.storeSubscription(this.subscription)
@@ -426,7 +426,7 @@ const end = new Date(Date.UTC(2000, 2, 1)).toISOString();
426426
2000-02-11T00:00:00.000Z 200 credit 200`);
427427
}
428428

429-
@test async multiSubscriptionOverlappingSessions() {
429+
@test async multiSubscriptionOverlappingSessions() {
430430
const subscriptionSwitchDate = hoursLater(start, 240);
431431
Subscription.cancelSubscription(this.subscription, subscriptionSwitchDate, oneMonthLater(this.subscription.startDate));
432432
await this.accountingDb.storeSubscription(this.subscription)
@@ -448,7 +448,7 @@ const end = new Date(Date.UTC(2000, 2, 1)).toISOString();
448448
2000-02-11T00:00:00.000Z 200 credit 200`);
449449
}
450450

451-
@test async multiSubscriptionOverlappingSession_2() {
451+
@test async multiSubscriptionOverlappingSession_2() {
452452
const subscriptionSwitchDate1 = hoursLater(start, 240);
453453
const subscriptionSwitchDate2 = hoursLater(start, 245);
454454
Subscription.cancelSubscription(this.subscription, subscriptionSwitchDate1, oneMonthLater(this.subscription.startDate));
@@ -529,7 +529,7 @@ const end = new Date(Date.UTC(2000, 2, 1)).toISOString();
529529
expect(await this.remainingHours(hoursLater(start, 200))).to.be.equal(10);
530530
}
531531

532-
@test async creditsAreBookedAgainstSessionsByAge() {
532+
@test async creditsAreBookedAgainstSessionsByAge() {
533533
const subscriptionWith40Hours = {
534534
...this.subscription,
535535
amount: 40
@@ -556,7 +556,7 @@ const end = new Date(Date.UTC(2000, 2, 1)).toISOString();
556556
}
557557

558558
// Test for https://github.com/TypeFox/gitpod/pull/3797#issuecomment-588170598
559-
@test async testPaidPlanWhileProOpenSource() {
559+
@test async testPaidPlanWhileProOpenSource() {
560560
Subscription.cancelSubscription(this.subscription, hoursLater(start, 1), oneMonthLater(this.subscription.startDate));
561561
await this.accountingDb.storeSubscription(this.subscription)
562562
await this.accountingDb.storeSubscription(await this.accountingDb.newSubscription({

components/ee/payment-endpoint/src/accounting/subscription-service.spec.db.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ const expect = chai.expect;
5858
await manager.clear(DBSubscription)
5959
}
6060

61-
@test.skip async subscriptions()  {
61+
@test.skip async subscriptions() {
6262
const start = new Date(Date.UTC(2000, 0, 1)).toISOString();
6363
const secondMonth = new Date(Date.UTC(2000, 1, 1)).toISOString();
6464
const thirdMonth = new Date(Date.UTC(2000, 2, 1)).toISOString();

components/gitpod-protocol/src/ide-frontend-service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import { Event } from "./util/event";
88
import { Disposable } from "./util/disposable";
99

10-
export type IDEFrontendState = 'init' | 'ready' | 'terminated';
10+
export type IDEFrontendState = 'init' | 'ready' | 'terminated';
1111

1212
export interface IDEFrontendService {
1313
readonly state: IDEFrontendState;

components/gitpod-protocol/src/util/gitpod-host-url.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ export class GitpodHostUrl {
150150
return undefined;
151151
}
152152

153-
get blobServe(): boolean {
153+
get blobServe(): boolean {
154154
const hostSegments = this.url.host.split(".");
155155
if (hostSegments[0] === 'blobserve') {
156156
return true;

components/server/ee/src/user/user-deletion-service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export class UserDeletionServiceEE extends UserDeletionService {
3939
// we do not care about transient plans
4040
continue;
4141
} else {
42-
if (!paymentReference) {
42+
if (!paymentReference) {
4343
const teamSlots = await this.teamSubscriptionService.findTeamSubscriptionSlotsByAssignee(id);
4444
teamSlots.forEach(async ts => await this.teamSubscriptionService.deactivateSlot(ts.teamSubscriptionId, ts.id, now))
4545
} else if (paymentReference.startsWith("github:")) {

components/server/ee/src/workspace/gitpod-server-impl.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1341,7 +1341,7 @@ export class GitpodServerEEImpl extends GitpodServerImpl {
13411341
return subscription;
13421342
}
13431343

1344-
// (SaaS) – admin
1344+
// (SaaS) – admin
13451345
async adminGetAccountStatement(ctx: TraceContext, userId: string): Promise<AccountStatement> {
13461346
traceAPIParams(ctx, { userId });
13471347

components/server/src/auth/generic-auth-provider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import { OutgoingHttpHeaders } from 'http2';
3333
* --
3434
* The main entrypoints go along the phases of the OAuth2 Authorization Code Flow:
3535
*
36-
* 1. `authorize` – this is called by the `Authenticator` to handle login/authorization requests.
36+
* 1. `authorize` – this is called by the `Authenticator` to handle login/authorization requests.
3737
*
3838
* The OAuth2 library under the hood will redirect send a redirect response to initialize the OAuth2 flow with the
3939
* authorization service.

components/server/src/auth/rate-limiter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { RateLimiterMemory, RateLimiterRes } from "rate-limiter-flexible";
1111

1212
export const accessCodeSyncStorage = 'accessCodeSyncStorage';
1313
export const accessHeadlessLogs = 'accessHeadlessLogs';
14-
type GitpodServerMethodType = keyof Omit<GitpodServer, "dispose" | "setClient"> | typeof accessCodeSyncStorage | typeof accessHeadlessLogs;
14+
type GitpodServerMethodType = keyof Omit<GitpodServer, "dispose" | "setClient"> | typeof accessCodeSyncStorage | typeof accessHeadlessLogs;
1515
type GroupsConfig = {
1616
[key: string]: {
1717
points: number,

components/server/src/workspace/git-token-scope-guesser.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export class GitTokenScopeGuesser {
2626

2727
// in case of git operation which require write access to a remote
2828
if (gitCommand === "push") {
29-
const validationResult = await this.tokenValidator.checkWriteAccess({ host: authProvider.host, repoFullName, token: currentToken.token });
29+
const validationResult = await this.tokenValidator.checkWriteAccess({ host: authProvider.host, repoFullName, token: currentToken.token });
3030
const hasWriteAccess = validationResult && validationResult.writeAccessToRepo === true;
3131
if (hasWriteAccess) {
3232
const isPublic = validationResult && !validationResult.isPrivateRepo;

components/server/src/workspace/workspace-starter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -805,7 +805,7 @@ export class WorkspaceStarter {
805805
"resource:"+ScopedResourceGuard.marshalResourceScope({kind: "token", subjectID: "*", operations: ["get"]}),
806806
"resource:"+ScopedResourceGuard.marshalResourceScope({kind: "contentBlob", subjectID: "*", operations: ["create", "get"]}),
807807
];
808-
if (CommitContext.is(workspace.context)) {
808+
if (CommitContext.is(workspace.context)) {
809809
const subjectID = workspace.context.repository.owner + '/' + workspace.context.repository.name;
810810
scopes.push(
811811
"resource:"+ScopedResourceGuard.marshalResourceScope({kind: "envVar", subjectID, operations: ["create", "get", "update", "delete"]}),

0 commit comments

Comments
 (0)