Skip to content

Commit 655281b

Browse files
easyCZroboquat
authored andcommitted
[public-api] Restructure packages to better align with other components
1 parent 2037329 commit 655281b

File tree

3 files changed

+56
-35
lines changed

3 files changed

+56
-35
lines changed

components/public-api-server/main.go

Lines changed: 3 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -5,45 +5,14 @@
55
package main
66

77
import (
8-
"github.com/gitpod-io/gitpod/common-go/baseserver"
98
"github.com/gitpod-io/gitpod/common-go/log"
10-
"github.com/gitpod-io/gitpod/public-api-server/middleware"
11-
"github.com/gitpod-io/gitpod/public-api-server/pkg/apiv1"
12-
v1 "github.com/gitpod-io/gitpod/public-api/v1"
13-
"net/http"
9+
"github.com/gitpod-io/gitpod/public-api-server/pkg/server"
1410
)
1511

1612
func main() {
1713
logger := log.New()
18-
srv, err := baseserver.New("public_api_server",
19-
baseserver.WithLogger(logger),
20-
baseserver.WithHTTPPort(9000),
21-
baseserver.WithGRPCPort(9001),
22-
)
23-
if err != nil {
24-
logger.WithError(err).Fatal("Failed to initialize public api server.")
25-
}
26-
27-
if err := register(srv); err != nil {
28-
logger.WithError(err).Fatal("Failed to register services.")
29-
}
3014

31-
if listenErr := srv.ListenAndServe(); listenErr != nil {
32-
logger.WithError(listenErr).Fatal("Failed to serve public api server")
15+
if err := server.Start(logger); err != nil {
16+
logger.WithError(err).Fatal("Server errored.")
3317
}
3418
}
35-
36-
func register(srv *baseserver.Server) error {
37-
logger := log.New()
38-
m := middleware.NewLoggingMiddleware(logger)
39-
srv.HTTPMux().Handle("/", m(http.HandlerFunc(HelloWorldHandler)))
40-
41-
v1.RegisterWorkspacesServiceServer(srv.GRPC(), apiv1.NewWorkspaceService())
42-
v1.RegisterPrebuildsServiceServer(srv.GRPC(), v1.UnimplementedPrebuildsServiceServer{})
43-
44-
return nil
45-
}
46-
47-
func HelloWorldHandler(w http.ResponseWriter, _ *http.Request) {
48-
w.Write([]byte(`hello world`))
49-
}

components/public-api-server/integration_test.go renamed to components/public-api-server/pkg/server/integration_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Licensed under the GNU Affero General Public License (AGPL).
33
// See License-AGPL.txt in the project root for license information.
44

5-
package main
5+
package server
66

77
import (
88
"context"
Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
// Copyright (c) 2022 Gitpod GmbH. All rights reserved.
2+
// Licensed under the GNU Affero General Public License (AGPL).
3+
// See License-AGPL.txt in the project root for license information.
4+
5+
package server
6+
7+
import (
8+
"fmt"
9+
"github.com/gitpod-io/gitpod/common-go/baseserver"
10+
"github.com/gitpod-io/gitpod/common-go/log"
11+
"github.com/gitpod-io/gitpod/public-api-server/middleware"
12+
"github.com/gitpod-io/gitpod/public-api-server/pkg/apiv1"
13+
v1 "github.com/gitpod-io/gitpod/public-api/v1"
14+
"github.com/sirupsen/logrus"
15+
"net/http"
16+
)
17+
18+
func Start(logger *logrus.Entry) error {
19+
srv, err := baseserver.New("public_api_server",
20+
baseserver.WithLogger(logger),
21+
baseserver.WithHTTPPort(9000),
22+
baseserver.WithGRPCPort(9001),
23+
)
24+
if err != nil {
25+
return fmt.Errorf("failed to initialize public api server: %w", err)
26+
}
27+
28+
if registerErr := register(srv); registerErr != nil {
29+
return fmt.Errorf("failed to register services: %w", registerErr)
30+
}
31+
32+
if listenErr := srv.ListenAndServe(); listenErr != nil {
33+
return fmt.Errorf("failed to serve public api server: %w", err)
34+
}
35+
36+
return nil
37+
}
38+
39+
func register(srv *baseserver.Server) error {
40+
logger := log.New()
41+
m := middleware.NewLoggingMiddleware(logger)
42+
srv.HTTPMux().Handle("/", m(http.HandlerFunc(HelloWorldHandler)))
43+
44+
v1.RegisterWorkspacesServiceServer(srv.GRPC(), apiv1.NewWorkspaceService())
45+
v1.RegisterPrebuildsServiceServer(srv.GRPC(), v1.UnimplementedPrebuildsServiceServer{})
46+
47+
return nil
48+
}
49+
50+
func HelloWorldHandler(w http.ResponseWriter, _ *http.Request) {
51+
w.Write([]byte(`hello world`))
52+
}

0 commit comments

Comments
 (0)