Skip to content

Commit 7e22f9b

Browse files
Apply suggestions from code review
Co-authored-by: Jan Keromnes <[email protected]>
1 parent bb97cd3 commit 7e22f9b

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

components/dashboard/src/settings/Preferences.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export default function Preferences() {
3434
const { setIsDark, isDark } = useContext(ThemeContext);
3535

3636
const updateUserIDEInfo = async (defaultDesktopIde: string, defaultIde: string) => {
37-
let useDesktopIde = defaultDesktopIde !== DesktopNoneId;
37+
const useDesktopIde = defaultDesktopIde !== DesktopNoneId;
3838
const additionalData = user?.additionalData ?? {};
3939
const settings = additionalData.ideSettings ?? {};
4040
settings.useDesktopIde = useDesktopIde;
@@ -116,7 +116,7 @@ export default function Preferences() {
116116
})
117117
}
118118
</div>
119-
{ideOptions.options[defaultIde] && ideOptions.options[defaultIde].notes &&
119+
{ideOptions.options[defaultIde]?.notes &&
120120
<InfoBox className="my-5 max-w-2xl"><ul>
121121
{ideOptions.options[defaultIde].notes?.map((x, idx) => <li className={idx > 0 ? "mt-2" : ""}>{x}</li>)}
122122
</ul></InfoBox>
@@ -131,14 +131,13 @@ export default function Preferences() {
131131
let selected = defaultDesktopIde === id;
132132
const onSelect = () => actuallySetDefaultDesktopIde(id);
133133
if (id === DesktopNoneId) {
134-
selected = defaultDesktopIde === DesktopNoneId
135134
option.logo = isDark ? DesktopNoneLogoDark : DesktopNoneLogoLight
136135
}
137136
return renderIdeOption(option, selected, onSelect);
138137
})
139138
}
140139
</div>
141-
{ideOptions.options[defaultDesktopIde] && ideOptions.options[defaultDesktopIde].notes &&
140+
{ideOptions.options[defaultDesktopIde]?.notes &&
142141
<InfoBox className="my-5 max-w-2xl"><ul>
143142
{ideOptions.options[defaultDesktopIde].notes?.map((x, idx) => <li className={idx > 0 ? "mt-2" : ""}>{x}</li>)}
144143
</ul></InfoBox>

0 commit comments

Comments
 (0)