[installer] Displable definitely-gp by default

Fixes #8740

`definitely-gp` is being deprecated soon, and hence
it is important to be disabled by default. Once it
is fully deprecated, even this option has to be removed.

For now, The following changes have been made:

- Update the `definitelyGpDisabled` option to be true, Thus
  disabling it by default both in the `installer` and `chart`.
- Update the airgap docs to remove a mention of this.

Signed-off-by: Tarun Pothulapati <[email protected]>

Author: Pothulapati

chart/values.yaml

@@ -300,7 +300,7 @@ components:
       minAgePrebuildDays: 7
       contentRetentionPeriodDays: 21
       contentChunkLimit: 1000
-    definitelyGpDisabled: "false"
+    definitelyGpDisabled: true
     enableLocalApp: false
     disableDynamicAuthProviderLogin: false
     maxEnvvarPerUserCount: 4048

install/installer/docs/air-gap.md

@@ -22,11 +22,10 @@ done
 
 ## Install Gitpod in Air-Gap Mode
 
-To install Gitpod in an air-gap network, you need to configure the repository of the images needed by Gitpod (see previous step) and disable the `definitely-gp` feature. Add this to your Gitpod config:
+To install Gitpod in an air-gap network, you need to configure the repository of the images needed by Gitpod (see previous step). Add this to your Gitpod config:
 
 ```yaml
 repository: your-registry.example.com
-disableDefinitelyGp: true
 ```
 
 That's it. Run the following commands as usual and Gitpod fetches the images from your registry and does not need internet access to operate:

install/installer/example-config.yaml

@@ -10,7 +10,7 @@ containerRegistry:
   inCluster: true
 database:
   inCluster: true
-disableDefinitelyGp: false
+disableDefinitelyGp: true
 domain: ""
 kind: Full
 metadata:

install/installer/pkg/config/v1/config.go

@@ -54,7 +54,7 @@ func (v version) Defaults(in interface{}) error {
 	cfg.Workspace.Runtime.ContainerDSocket = "/run/containerd/containerd.sock"
 	cfg.Workspace.Runtime.ContainerDRuntimeDir = "/var/lib/containerd/io.containerd.runtime.v2.task/k8s.io"
 	cfg.OpenVSX.URL = "https://open-vsx.org"
-	cfg.DisableDefinitelyGP = false
+	cfg.DisableDefinitelyGP = true
 
 	return nil
 }