Skip to content

Commit 8a20df8

Browse files
easyCZeasyCZ
committed
[public-api] Remove gp-lint
1 parent c6fec61 commit 8a20df8

20 files changed

+483
-1537
lines changed

‎components/public-api-server/pkg/apiv1/workspace.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ type WorkspaceService struct {
2121

2222
func (w *WorkspaceService) GetWorkspace(ctx context.Context, r *v1.GetWorkspaceRequest) (*v1.GetWorkspaceResponse, error) {
2323
return &v1.GetWorkspaceResponse{
24-
ResponseStatus: nil,
2524
Result: &v1.Workspace{
2625
WorkspaceId: r.GetWorkspaceId(),
2726
OwnerId: "mock_owner",

‎components/public-api-server/pkg/apiv1/workspace_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ func TestWorkspaceService_GetWorkspace(t *testing.T) {
2020
})
2121
require.NoError(t, err)
2222
require.Equal(t, &v1.GetWorkspaceResponse{
23-
ResponseStatus: nil,
2423
Result: &v1.Workspace{
2524
WorkspaceId: workspaceID,
2625
OwnerId: "mock_owner",

‎components/public-api/BUILD.yaml

Lines changed: 0 additions & 9 deletions
This file was deleted.

‎components/public-api/generate.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ COMPONENTS_DIR="$ROOT_DIR"/components
1818
source "$ROOT_DIR"/scripts/protoc-generator.sh
1919

2020
lint
21-
leeway run .:lint
2221

2322
install_dependencies
2423
go_protoc "$COMPONENTS_DIR" "gitpod/v1"

‎components/public-api/gitpod/v1/prebuilds.proto

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ syntax = "proto3";
33
package gitpod.v1;
44

55
import "gitpod/v1/workspaces.proto";
6-
import "google/rpc/status.proto";
76

87
option go_package = "github.com/gitpod-io/gitpod/public-api/v1";
98

@@ -34,36 +33,28 @@ message GetPrebuildRequest {
3433
string prebuild_id = 1;
3534
}
3635
message GetPrebuildResponse {
37-
google.rpc.Status response_status = 1;
38-
39-
Prebuild prebuild = 2;
36+
Prebuild prebuild = 1;
4037
}
4138

4239
message GetRunningPrebuildRequest {
4340
string context_url = 1;
4441
}
4542
message GetRunningPrebuildResponse {
46-
google.rpc.Status response_status = 1;
47-
48-
Prebuild prebuild = 2;
43+
Prebuild prebuild = 1;
4944
}
5045

5146
message ListenToPrebuildStatusRequest{
5247
string prebuild_id = 1;
5348
}
5449
message ListenToPrebuildStatusResponse {
55-
google.rpc.Status response_status = 1;
56-
57-
PrebuildStatus status = 2;
50+
PrebuildStatus status = 1;
5851
}
5952

6053
message ListenToPrebuildLogsRequest {
6154
string prebuild_id = 1;
6255
}
6356
message ListenToPrebuildLogsResponse {
64-
google.rpc.Status response_status = 1;
65-
66-
string line = 2;
57+
string line = 1;
6758
}
6859

6960
////////////////////////////////

‎components/public-api/gitpod/v1/workspaces.proto

Lines changed: 11 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ option go_package = "github.com/gitpod-io/gitpod/public-api/v1";
66

77
import "google/protobuf/timestamp.proto";
88
import "google/protobuf/field_mask.proto";
9-
import "google/rpc/status.proto";
109
import "gitpod/v1/pagination.proto";
1110

1211
service WorkspacesService {
@@ -58,20 +57,16 @@ message ListWorkspacesResponse {
5857
WorkspaceInstance last_active_instances = 2;
5958
}
6059

61-
google.rpc.Status response_status = 1;
60+
string next_page_token = 1;
6261

63-
string next_page_token = 2;
64-
65-
repeated WorkspaceAndInstance result = 3;
62+
repeated WorkspaceAndInstance result = 2;
6663
}
6764

6865
message GetWorkspaceRequest {
6966
string workspace_id = 1;
7067
}
7168
message GetWorkspaceResponse {
72-
google.rpc.Status response_status = 1;
73-
74-
Workspace result = 2;
69+
Workspace result = 1;
7570
}
7671

7772
message CreateAndStartWorkspaceRequest {
@@ -85,9 +80,7 @@ message CreateAndStartWorkspaceRequest {
8580
StartWorkspaceSpec start_spec = 5;
8681
}
8782
message CreateAndStartWorkspaceResponse {
88-
google.rpc.Status response_status = 1;
89-
90-
string workspace_id = 2;
83+
string workspace_id = 1;
9184
}
9285

9386
message StartWorkspaceRequest {
@@ -97,56 +90,44 @@ message StartWorkspaceRequest {
9790
StartWorkspaceSpec spec = 3;
9891
}
9992
message StartWorkspaceResponse {
100-
google.rpc.Status response_status = 1;
101-
102-
string instance_id = 2;
103-
string workspace_url = 3;
93+
string instance_id = 1;
94+
string workspace_url = 2;
10495
}
10596

10697
message GetActiveWorkspaceInstanceRequest {
10798
string workspace_id = 1;
10899
}
109100
message GetActiveWorkspaceInstanceResponse {
110-
google.rpc.Status response_status = 1;
111-
112-
WorkspaceInstance instance = 2;
101+
WorkspaceInstance instance = 1;
113102
}
114103

115104
message GetWorkspaceInstanceOwnerTokenRequest {
116105
string instance_id = 1;
117106
}
118107
message GetWorkspaceInstanceOwnerTokenResponse {
119-
google.rpc.Status response_status = 1;
120-
121-
string owner_token = 2;
108+
string owner_token = 1;
122109
}
123110

124111
message ListenToWorkspaceInstanceRequest {
125112
string instance_id = 1;
126113
}
127114
message ListenToWorkspaceInstanceResponse {
128-
google.rpc.Status response_status = 1;
129-
130-
WorkspaceInstanceStatus instance_status = 2;
115+
WorkspaceInstanceStatus instance_status = 1;
131116
}
132117

133118
message ListenToImageBuildLogsRequest {
134119
string instance_id = 1;
135120
}
136121
message ListenToImageBuildLogsResponse {
137-
google.rpc.Status response_status = 1;
138-
139-
string line = 2;
122+
string line = 1;
140123
}
141124

142125
message StopWorkspaceRequest {
143126
string idempotency_token = 1;
144127

145128
string workspace_id = 2;
146129
}
147-
message StopWorkspaceResponse {
148-
google.rpc.Status response_status = 1;
149-
}
130+
message StopWorkspaceResponse {}
150131

151132
////////////////////////////////
152133
// Shared messages come here

0 commit comments

Comments
 (0)