[server] generate better workspace ids

Author: svenefftinge

components/server/package.json

@@ -76,6 +76,7 @@
     "request": "^2.87.0",
     "request-promise": "^4.2.2",
     "swot-js": "^1.0.3",
+    "unique-names-generator": "^4.3.1",
     "uuid": "^3.1.0",
     "vscode-ws-jsonrpc": "^0.2.0",
     "ws": "^5.2.2"

components/server/src/workspace/workspace-factory.ts

@@ -21,6 +21,7 @@ import { ImageBuilderClientProvider } from '@gitpod/image-builder/lib';
 import { TracedWorkspaceDB, DBWithTracing } from '@gitpod/gitpod-db/lib/traced-db';
 import { ImageSourceProvider } from './image-source-provider';
 import { TheiaPluginService } from '../theia-plugin/theia-plugin-service';
+import { uniqueNamesGenerator, adjectives, colors, animals } from 'unique-names-generator';
 
 @injectable()
 export class WorkspaceFactory {
@@ -188,12 +189,13 @@ export class WorkspaceFactory {
     }
 
     protected generateWorkspaceId(): string {
-        var uuid
-        do {
-            uuid = uuidv4()
-        }
-        while (uuid.charAt(0).match("[0-9]") != null)   // No numbers as first char, as we use this id as DNS name
-        return uuid
+        const randomName: string = uniqueNamesGenerator({
+            dictionaries: [adjectives, colors, animals],
+            separator: '-',
+            length: 3,
+        });
+        
+        return randomName + "-" + uuidv4().substring(0,8);
     }
 
 }

yarn.lock

@@ -19321,6 +19321,11 @@ unique-filename@^1.1.0, unique-filename@^1.1.1:
   dependencies:
     unique-slug "^2.0.0"
 
+unique-names-generator@^4.3.1:
+  version "4.3.1"
+  resolved "https://registry.yarnpkg.com/unique-names-generator/-/unique-names-generator-4.3.1.tgz#f61ec2290b2f865894af01afb40f3e1043bb8fa2"
+  integrity sha512-oxkKrDXbwx6I5M963SdfmMH2t8n1OIfYyzoJ25BmDeETlyWAZjTbMXwIEMiQDex4lkD2pqe+9gxDJQAB2IOfDg==
+
 unique-slug@^2.0.0:
   version "2.0.1"
   resolved "https://registry.yarnpkg.com/unique-slug/-/unique-slug-2.0.1.tgz#5e9edc6d1ce8fb264db18a507ef9bd8544451ca6"