v4

Author: jankeromnes

components/server/src/github/github-context-parser.spec.ts

@@ -320,7 +320,6 @@ class TestGithubContextParser {
         })
     }
 
-
     @test public async testCommitContext_02_notExistingCommit() {
         try {
             await this.parser.handle({}, this.user, 'https://github.com/gitpod-io/gitpod-test-repo/commit/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa');
@@ -537,5 +536,13 @@ class TestGithubContextParser {
         )
     }
 
+    @test public async testFetchCommitHistory() {
+        const result = await this.parser.fetchCommitHistory({}, this.user, 'https://github.com/gitpod-io/gitpod-test-repo', '409ac2de49a53d679989d438735f78204f441634');
+        expect(result).to.deep.equal([
+            '506e5aed317f28023994ecf8ca6ed91430e9c1a4',
+            'f5b041513bfab914b5fbf7ae55788d9835004d76',
+        ])
+    }
+
 }
 module.exports = new TestGithubContextParser()   // Only to circumvent no usage warning :-/

components/server/src/github/github-context-parser.ts

@@ -420,7 +420,7 @@ export class GithubContextParser extends AbstractContextParser implements IConte
     public async fetchCommitHistory(ctx: TraceContext, user: User, contextUrl: string, sha: string): Promise<string[]> {
         const span = TraceContext.startSpan("GithubContextParser.fetchCommitHistory", ctx);
         const maxDepth = 100;
-        const maxAgeMs = 1000 * 3600 * 24 * 10;
+        // const maxAgeMs = 1000 * 3600 * 24 * 10;
 
         try {
             if (sha.length != 40) {
@@ -439,7 +439,7 @@ export class GithubContextParser extends AbstractContextParser implements IConte
                     repository(name: "${repoName}", owner: "${owner}") {
                         object(oid: "${sha}") {
                             ... on Commit {
-                                history(first: ${maxDepth}, since: "${new Date(Date.now() - maxAgeMs).toISOString()}") {
+                                history(first: ${maxDepth}` + /* , since: "${new Date(Date.now() - maxAgeMs).toISOString()}" */ `) {
                                     edges {
                                         node {
                                             oid

components/server/src/gitlab/gitlab-context-parser.spec.ts

@@ -547,6 +547,14 @@ class TestGitlabContextParser {
         })
     }
 
+    @test public async testFetchCommitHistory() {
+        const result = await this.parser.fetchCommitHistory({}, this.user, 'https://gitlab.com/AlexTugarev/gp-test', '80948e8cc8f0e851e89a10bc7c2ee234d1a5fbe7');
+        expect(result).to.deep.equal([
+            '4447fbc4d46e6fd1ee41fb1b992702521ae078eb',
+            'f2d9790f2752a794517b949c65a773eb864844cd',
+        ])
+    }
+
 }
 
 module.exports = new TestGitlabContextParser();

components/server/src/gitlab/gitlab-context-parser.ts

@@ -340,8 +340,26 @@ export class GitlabContextParser extends AbstractContextParser implements IConte
         };
     }
 
-    public async fetchCommitHistory(ctx: TraceContext, user: User, contextUrl: string, commit: string): Promise<string[]> {
-        // FIXME
-        return [];
+    public async fetchCommitHistory(ctx: TraceContext, user: User, contextUrl: string, sha: string): Promise<string[]> {
+        const maxDepth = 100;
+        // const maxAgeMs = 1000 * 3600 * 24 * 100;
+
+        const { owner, repoName } = await this.parseURL(user, contextUrl);
+        const projectId = `${owner}/${repoName}`;
+        const result = await this.gitlabApi.run<GitLab.Commit[]>(user, async g => {
+            return g.Commits.all(projectId, {
+                ref_name: sha,
+                // since: new Date(Date.now() - maxAgeMs).toISOString(),
+                per_page: maxDepth,
+                page: 1,
+            });
+        });
+        if (GitLab.ApiError.is(result)) {
+            if (result.message === 'GitLab responded with code 404') {
+                throw new Error(`Couldn't find commit #${sha} in repository ${projectId}.`);
+            }
+            throw result;
+        }
+        return result.slice(1).map((c: GitLab.Commit) => c.id);
     }
 }