Fix

Author: easyCZ

install/installer/pkg/components/public-api-server/deployment.go

@@ -47,8 +47,8 @@ func deployment(ctx *common.RenderContext) ([]runtime.Object, error) {
 							Name:  Component,
 							Image: ctx.ImageName(ctx.Config.Repository, Component, ctx.VersionManifest.Components.PublicAPIServer.Version),
 							Args: []string{
-								fmt.Sprintf(`--http-port="%d"`, HTTPContainerPort),
-								fmt.Sprintf(`--grpc-port="%d"`, GRPCContainerPort),
+								fmt.Sprintf(`--http-port=%d`, HTTPContainerPort),
+								fmt.Sprintf(`--grpc-port=%d`, GRPCContainerPort),
 								fmt.Sprintf(`--gitpod-api-url="wss://%s/api/v1"`, ctx.Config.Domain),
 							},
 							ImagePullPolicy: corev1.PullIfNotPresent,

install/installer/pkg/components/public-api-server/deployment_test.go

@@ -20,3 +20,23 @@ func TestDeployment(t *testing.T) {
 	dpl := objects[0].(*appsv1.Deployment)
 	require.Len(t, dpl.Spec.Template.Spec.Containers, 2, "must render 2 containers")
 }
+
+func TestDeployment_ServerArguments(t *testing.T) {
+	ctx := renderContextWithPublicAPIEnabled(t)
+
+	objects, err := deployment(ctx)
+	require.NoError(t, err)
+
+	require.Len(t, objects, 1, "must render only one object")
+
+	dpl := objects[0].(*appsv1.Deployment)
+	containers := dpl.Spec.Template.Spec.Containers
+	require.Equal(t, Component, containers[0].Name)
+
+	apiContainer := containers[0]
+	require.EqualValues(t, []string{
+		"--http-port=9000",
+		"--grpc-port=9001",
+		`--gitpod-api-url="wss://test.domain.everything.awesome.is/api/v1"`,
+	}, apiContainer.Args)
+}

install/installer/pkg/components/public-api-server/objects_test.go

@@ -31,6 +31,7 @@ func TestObjects_RenderedWhenExperimentalConfigSet(t *testing.T) {
 
 func renderContextWithPublicAPIEnabled(t *testing.T) *common.RenderContext {
 	ctx, err := common.NewRenderContext(config.Config{
+		Domain: "test.domain.everything.awesome.is",
 		Experimental: &experimental.Config{
 			WebApp: &experimental.WebAppConfig{
 				PublicAPI: &experimental.PublicAPIConfig{Enabled: true},