Skip to content

Commit c73212d

Browse files
aledbfnandajavarma
authored andcommitted
Log JSON as strings not an array of bytes
1 parent 6daf6aa commit c73212d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

components/image-builder-mk3/pkg/orchestrator/orchestrator.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ func (o *Orchestrator) ResolveBaseImage(ctx context.Context, req *protocol.Resol
151151

152152
reqs, _ := protojson.Marshal(req)
153153
safeReqs, _ := log.RedactJSON(reqs)
154-
log.WithField("req", safeReqs).Debug("ResolveBaseImage")
154+
log.WithField("req", string(safeReqs)).Debug("ResolveBaseImage")
155155

156156
reqauth := o.AuthResolver.ResolveRequestAuth(req.Auth)
157157

@@ -173,7 +173,7 @@ func (o *Orchestrator) ResolveWorkspaceImage(ctx context.Context, req *protocol.
173173

174174
reqs, _ := protojson.Marshal(req)
175175
safeReqs, _ := log.RedactJSON(reqs)
176-
log.WithField("req", safeReqs).Debug("ResolveWorkspaceImage")
176+
log.WithField("req", string(safeReqs)).Debug("ResolveWorkspaceImage")
177177

178178
reqauth := o.AuthResolver.ResolveRequestAuth(req.Auth)
179179
baseref, err := o.getBaseImageRef(ctx, req.Source, reqauth)

components/ws-manager/pkg/manager/manager.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1369,12 +1369,12 @@ func (m *Manager) onChange(ctx context.Context, status *api.WorkspaceStatus) {
13691369
if status.Conditions.Failed != "" {
13701370
status, _ := protojson.Marshal(status)
13711371
safeStatus, _ := log.RedactJSON(status)
1372-
clog.WithField("status", safeStatus).Error("workspace failed")
1372+
clog.WithField("status", string(safeStatus)).Error("workspace failed")
13731373
}
13741374
if status.Phase == 0 {
13751375
status, _ := protojson.Marshal(status)
13761376
safeStatus, _ := log.RedactJSON(status)
1377-
clog.WithField("status", safeStatus).Error("workspace in UNKNOWN phase")
1377+
clog.WithField("status", string(safeStatus)).Error("workspace in UNKNOWN phase")
13781378
}
13791379
}
13801380

0 commit comments

Comments
 (0)