Skip to content

Commit ce79a83

Browse files
committed
[ws-manager] refactory image layers
1 parent 80bf829 commit ce79a83

File tree

7 files changed

+600
-359
lines changed

7 files changed

+600
-359
lines changed

components/ws-manager-api/core.proto

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -314,11 +314,11 @@ message WorkspaceStatus {
314314
message IDEImage {
315315
// web_ref is a reference to an OCI image used for serving the web-based IDE
316316
string web_ref = 1;
317-
// desktop_ref is an optional reference to an OCI image used for serving desktop IDEs
317+
// DEPRECATED desktop_ref is an optional reference to an OCI image used for serving desktop IDEs
318318
string desktop_ref = 2;
319319
// supervisor_ref is a reference to an OCI image used as supervisor
320320
string supervisor_ref = 3;
321-
// desktop_plugin_ref is an optional reference to an OCI image used for serving desktop IDE plugin
321+
// DEPRECATED desktop_plugin_ref is an optional reference to an OCI image used for serving desktop IDE plugin
322322
string desktop_plugin_ref = 4;
323323
}
324324

@@ -351,6 +351,10 @@ message WorkspaceSpec {
351351

352352
// class names the class of this workspace
353353
string class = 9;
354+
355+
// ide_image_layers are contains the images needed for the ide to run,
356+
// including ide-desktop, desktop-plugin and so on
357+
repeated string ide_image_layers = 10;
354358
}
355359

356360
// PortSpec describes a networking port exposed on a workspace
@@ -567,6 +571,13 @@ message StartWorkspaceSpec {
567571

568572
// ssh_public_keys is user's uploaded ssh public keys
569573
repeated string ssh_public_keys = 15;
574+
575+
// sys_envvars are system level environment variables which ought to be available in the workspace
576+
repeated EnvironmentVariable sys_envvars = 16;
577+
578+
// ide_image_layers are contains the images needed for the ide to run,
579+
// including ide-desktop, desktop-plugin and so on
580+
repeated string ide_image_layers = 17;
570581
}
571582

572583
// WorkspaceFeatureFlag enable non-standard behaviour in workspaces

components/ws-manager-api/go/core.pb.go

Lines changed: 360 additions & 321 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

components/ws-manager-api/typescript/src/core_pb.d.ts

Lines changed: 15 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

components/ws-manager-api/typescript/src/core_pb.js

Lines changed: 155 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)