Minor improvements to the workspace timeout validation

1. Only allow decimal values in timeouts
    This allowed users to have durations in other number systems like hexadecimal. For example `0xfd` was a valid timeout.
2. Remove "d" (day) as a unit
    Because this unit is both rejected by the backend and timeouts cannot be longer than 24 hours, it does not make sense to allow it.

Co-authored-by: Lou Bichard <[email protected]>

Author: filiptronicek

components/gitpod-protocol/src/gitpod-service.ts

@@ -363,19 +363,20 @@ const WORKSPACE_MAXIMUM_TIMEOUT_HOURS = 24;
 export type WorkspaceTimeoutDuration = string;
 export namespace WorkspaceTimeoutDuration {
     export function validate(duration: string): WorkspaceTimeoutDuration {
+        duration = duration.toLowerCase();
         const unit = duration.slice(-1);
-        if (!["m", "h", "d"].includes(unit)) {
+        if (!["m", "h"].includes(unit)) {
             throw new Error(`Invalid timeout unit: ${unit}`);
         }
-        const value = parseInt(duration.slice(0, -1));
+        const value = parseInt(duration.slice(0, -1), 10);
         if (isNaN(value) || value <= 0) {
             throw new Error(`Invalid timeout value: ${duration}`);
         }
         if (
             (unit === "h" && value > WORKSPACE_MAXIMUM_TIMEOUT_HOURS) ||
             (unit === "m" && value > WORKSPACE_MAXIMUM_TIMEOUT_HOURS * 60)
         ) {
-            throw new Error(`Timeouts cannot extend to more than a day`);
+            throw new Error("Workspace inactivity timeout cannot exceed 24h");
         }
         return duration;
     }