Skip to content

Commit d7e0685

Browse files
committed
[server][protocol] Refactor: Move censor function from server into gitpod-protocol
1 parent 61cac29 commit d7e0685

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
/**
2+
* Copyright (c) 2021 Gitpod GmbH. All rights reserved.
3+
* Licensed under the GNU Affero General Public License (AGPL).
4+
* See License-AGPL.txt in the project root for license information.
5+
*/
6+
7+
export function censor<T>(obj: T, k: keyof T): T {
8+
const r = { ...obj };
9+
delete (r as any)[k];
10+
return r;
11+
}

components/server/ee/src/workspace/gitpod-server-impl.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
*/
66

77
import { injectable, inject } from "inversify";
8-
import { GitpodServerImpl, traceAPIParams, traceWI, censor } from "../../../src/workspace/gitpod-server-impl";
8+
import { GitpodServerImpl, traceAPIParams, traceWI } from "../../../src/workspace/gitpod-server-impl";
9+
import { censor } from '@gitpod/gitpod-protocol/lib/util/censor';
910
import { TraceContext } from "@gitpod/gitpod-protocol/lib/util/tracing";
1011
import { GitpodServer, GitpodClient, AdminGetListRequest, User, AdminGetListResult, Permission, AdminBlockUserRequest, AdminModifyRoleOrPermissionRequest, RoleOrPermission, AdminModifyPermanentWorkspaceFeatureFlagRequest, UserFeatureSettings, AdminGetWorkspacesRequest, WorkspaceAndInstance, GetWorkspaceTimeoutResult, WorkspaceTimeoutDuration, WorkspaceTimeoutValues, SetWorkspaceTimeoutResult, WorkspaceContext, CreateWorkspaceMode, WorkspaceCreationResult, PrebuiltWorkspaceContext, CommitContext, PrebuiltWorkspace, PermissionName, WorkspaceInstance, EduEmailDomain, ProviderRepository, Queue, PrebuildWithStatus, CreateProjectParams, Project, StartPrebuildResult, ClientHeaderFields, Workspace } from "@gitpod/gitpod-protocol";
1112
import { ResponseError } from "vscode-jsonrpc";

components/server/src/workspace/gitpod-server-impl.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import { ErrorCodes } from '@gitpod/gitpod-protocol/lib/messaging/error';
1515
import { GithubUpgradeURL, PlanCoupon } from "@gitpod/gitpod-protocol/lib/payment-protocol";
1616
import { TeamSubscription, TeamSubscriptionSlot, TeamSubscriptionSlotResolved } from "@gitpod/gitpod-protocol/lib/team-subscription-protocol";
1717
import { Cancelable } from '@gitpod/gitpod-protocol/lib/util/cancelable';
18+
import { censor } from '@gitpod/gitpod-protocol/lib/util/censor';
1819
import { log, LogContext } from '@gitpod/gitpod-protocol/lib/util/logging';
1920
import { InterfaceWithTraceContext, TraceContext } from '@gitpod/gitpod-protocol/lib/util/tracing';
2021
import { IdentifyMessage, PageMessage, RemoteIdentifyMessage, RemotePageMessage, RemoteTrackMessage, TrackMessage } from '@gitpod/gitpod-protocol/lib/analytics';
@@ -59,8 +60,6 @@ import { ClientMetadata } from '../websocket/websocket-connection-manager';
5960
// shortcut
6061
export const traceWI = (ctx: TraceContext, wi: Omit<LogContext, "userId">) => TraceContext.setOWI(ctx, wi); // userId is already taken care of in WebsocketConnectionManager
6162
export const traceAPIParams = (ctx: TraceContext, params: { [key: string]: any }) => TraceContext.addJsonRPCParameters(ctx, params);
62-
export function censor<T>(obj: T, k: keyof T): T { const r = { ...obj }; delete (r as any)[k]; return r; }
63-
6463

6564
export type GitpodServerWithTracing = InterfaceWithTraceContext<GitpodServer>;
6665

0 commit comments

Comments
 (0)