WIP: Added inline TODO

mads-hartmann · mads-hartmann · commit f1fb044f9d79 · 2021-04-29T12:04:54.000Z
diff --git a/components/gitpod-db/src/typeorm/workspace-db-impl.ts b/components/gitpod-db/src/typeorm/workspace-db-impl.ts
@@ -703,6 +703,11 @@ export abstract class AbstractTypeORMWorkspaceDBImpl extends AbstractWorkspaceDB
             joinConditions.push("ws.ownerId = :ownerId");
             joinConditionParams.ownerId = ownerId;
         }
+
+        // TODO: I could extend this with more join conditions so it also looks for
+        // - workspaces name (e.g "pink-teddybear-1245") aka workspace-ID
+        // - instance-UUID
+        // TODO: Figure out how to describe the ws table so I know what to join on
         if (!!searchTerm) {
             joinConditions.push(`ws.contextUrl LIKE '%${searchTerm}%'`);
         }

Original file line number	Diff line number	Diff line change
`@@ -703,6 +703,11 @@ export abstract class AbstractTypeORMWorkspaceDBImpl extends AbstractWorkspaceDB`
`703`	`703`	`joinConditions.push("ws.ownerId = :ownerId");`
`704`	`704`	`joinConditionParams.ownerId = ownerId;`
`705`	`705`	`}`
	`706`	`+`
	`707`	`+ // TODO: I could extend this with more join conditions so it also looks for`
	`708`	`+ // - workspaces name (e.g "pink-teddybear-1245") aka workspace-ID`
	`709`	`+ // - instance-UUID`
	`710`	`+ // TODO: Figure out how to describe the ws table so I know what to join on`
`706`	`711`	`if (!!searchTerm) {`
`707`	`712`	joinConditions.push(`ws.contextUrl LIKE '%${searchTerm}%'`);
`708`	`713`	`}`