[ws-manager] fix not handling workspaces that are completed

Author: sagor999

components/ws-manager/pkg/manager/status.go

@@ -495,6 +495,10 @@ func (m *Manager) extractStatusFromPod(result *api.WorkspaceStatus, wso workspac
 		result.Phase = api.WorkspacePhase_STOPPING
 		result.Message = "headless workspace is stopping"
 		return nil
+	} else if status.Phase == corev1.PodSucceeded {
+		result.Phase = api.WorkspacePhase_STOPPING
+		result.Message = "workspace is stopping"
+		return nil
 	} else if status.Phase == corev1.PodUnknown {
 		result.Phase = api.WorkspacePhase_UNKNOWN
 		result.Message = "Kubernetes reports workspace phase as unknown"

components/ws-manager/pkg/manager/testdata/actOnPodEvent_workspaceCompleted_01.golden

@@ -0,0 +1,23 @@
+{
+    "actions": [
+        {
+            "Func": "clearInitializerFromMap",
+            "Params": {
+                "podName": "ws-75ca49e0-c4e6-4eb0-896f-aec069880f93"
+            }
+        },
+        {
+            "Func": "deleteWorkspaceSecrets",
+            "Params": {
+                "podName": "ws-75ca49e0-c4e6-4eb0-896f-aec069880f93"
+            }
+        },
+        {
+            "Func": "stopWorkspace",
+            "Params": {
+                "gracePeriod": 30000000000,
+                "workspaceID": "75ca49e0-c4e6-4eb0-896f-aec069880f93"
+            }
+        }
+    ]
+}

components/ws-manager/pkg/manager/testdata/status_workspaceCompleted_01.golden

@@ -0,0 +1,41 @@
+{
+    "status": {
+        "id": "75ca49e0-c4e6-4eb0-896f-aec069880f93",
+        "status_version": 65536,
+        "metadata": {
+            "owner": "32a9048a-6037-4571-a96f-f640fc949bd0",
+            "meta_id": "giaa0502-ddos-kd27l9j4i3c",
+            "started_at": {
+                "seconds": 1659327428
+            }
+        },
+        "spec": {
+            "workspace_image": "eu.gcr.io/gitpod-dev/workspace-images:14fe8d8eced804f7ab64fff765bd9b98d7c27fc485e52cf50d11b73a1daf49e9",
+            "deprecated_ide_image": "eu.gcr.io/gitpod-core-dev/build/ide/code:commit-079f161f0aaf95d6b5e28f0709b3e629337291e9",
+            "url": "https://giaa0502-ddos-kd27l9j4i3c.ws-us58.gitpod.io",
+            "exposed_ports": [
+                {
+                    "port": 3000,
+                    "url": "https://3000-giaa0502-ddos-kd27l9j4i3c.ws-us58.gitpod.io"
+                }
+            ],
+            "timeout": "30m",
+            "ide_image": {
+                "web_ref": "eu.gcr.io/gitpod-core-dev/build/ide/code:commit-079f161f0aaf95d6b5e28f0709b3e629337291e9",
+                "supervisor_ref": "eu.gcr.io/gitpod-core-dev/build/supervisor:commit-2e2a3d535732efd8c38868810b73e5fde3239002"
+            },
+            "class": "default"
+        },
+        "phase": 5,
+        "conditions": {
+            "volume_snapshot": {}
+        },
+        "message": "workspace is stopping",
+        "runtime": {
+            "node_name": "workspace-ws-us58-pool-qx7j",
+            "pod_name": "ws-75ca49e0-c4e6-4eb0-896f-aec069880f93",
+            "node_ip": "10.10.0.9"
+        },
+        "auth": {}
+    }
+}