Skip to content

extract cgroup library from ws-daemon in supervisor #10043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akosyakov opened this issue May 16, 2022 · 5 comments
Closed

extract cgroup library from ws-daemon in supervisor #10043

akosyakov opened this issue May 16, 2022 · 5 comments
Labels
aspect: tech-debt Issues related to engineering tech debt component: supervisor component: ws-daemon team: IDE team: workspace Issue belongs to the Workspace team

Comments

@akosyakov
Copy link
Member

akosyakov commented May 16, 2022

Supervisor and ws-daemon both need information provided by cgroups, but have slightly different implementation. We need to extract a common go library.

See this discussion for more context.

@akosyakov akosyakov added component: supervisor component: ws-daemon team: workspace Issue belongs to the Workspace team team: IDE aspect: tech-debt Issues related to engineering tech debt labels May 16, 2022
@Furisto
Copy link
Member

Furisto commented May 24, 2022

@akosyakov I discussed this with @kylos101 and these are the tasks that we think need to be completed:

  • Create the cgroup library
  • Switch workspace components to the library
  • Extend IWS with an endpoint that provides resource information that is using this library
  • Supervisor uses this endpoint to retrieve resource information. That way the IDE team does not need to mess with linux and workspace implementation details.

Do you agree with the direction and is there anything else that you would need?

@akosyakov
Copy link
Member Author

It sounds good then the workspace team is going to take care about it?

@kylos101
Copy link
Contributor

It sounds good then the workspace team is going to take care about it?

@akosyakov the first 3 bullets, yes, I think so. For the 4th, for supervisor to use new IWS endpoint, what do you think? I thought IDE team may want to do consumption of the new IWS endpoint from supervisor.

@akosyakov
Copy link
Member Author

I think you need to refactor supervisor as well to make sure that library is aligned with our expectations.

@Furisto
Copy link
Member

Furisto commented Jun 29, 2022

Solved by #10836

@Furisto Furisto closed this as completed Jun 29, 2022
@Furisto Furisto moved this to Done in 🌌 Workspace Team Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: tech-debt Issues related to engineering tech debt component: supervisor component: ws-daemon team: IDE team: workspace Issue belongs to the Workspace team
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants