Skip to content

[GP CLI] Automatically disable output colorization when not required #10633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andreafalzetti opened this issue Jun 13, 2022 · 0 comments · Fixed by #10638
Closed

[GP CLI] Automatically disable output colorization when not required #10633

andreafalzetti opened this issue Jun 13, 2022 · 0 comments · Fixed by #10638
Assignees
@andreafalzetti
Labels
component: gp cli team: IDE type: bug Something isn't working

Comments

@andreafalzetti
Copy link
Contributor

Bug description

When using gp CLI in addition to other programs via stdin/stout, (e.g. watch), the output colorization ruins the user experience because the colors are not supported and are actually rendered as ASCII characters.

Steps to reproduce

  1. Launch a workspace
  2. Run watch gp ports list or watch gp tasks list

It will look like:

Screenshot 2022-06-13 at 12 16 55

Screenshot 2022-06-13 at 12 16 48

Workspace affected

No response

Expected behavior

The output colorization is automatically disabled. We can now implement this thanks to https://github.com/gitpod-io/gitpod/pull/10570/files#diff-7d3a206fbf5ce6606b82d0f45db9ed5d3100ba0116e94a052047835e1ef8ea53

Example repository

No response

Anything else?

No response
@andreafalzetti andreafalzetti self-assigned this Jun 13, 2022
@andreafalzetti andreafalzetti changed the title [GP CLI] Disable colors for commands using the new utility [GP CLI] Automatically disable output colorization when not required Jun 13, 2022
@andreafalzetti andreafalzetti mentioned this issue Jun 13, 2022
Closed
@andreafalzetti andreafalzetti moved this to In Progress in 🚀 IDE Team Jun 13, 2022
@andreafalzetti andreafalzetti mentioned this issue Jun 13, 2022
Merged
@andreafalzetti andreafalzetti moved this from In Progress to In Review in 🚀 IDE Team Jun 13, 2022
@mustard-mh mustard-mh moved this from In Review to Done in 🚀 IDE Team Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreafalzetti andreafalzetti

Labels
component: gp cli team: IDE type: bug Something isn't working
Projects
🚀 IDE Team
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GP CLI] Allow explicity and automated disabling of output colorization gitpod-io/gitpod
1 participant
@andreafalzetti