Skip to content

Import SSH public keys from 3rd parties (GitHub, GitLab, BitBucket) #11370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loujaybee opened this issue Jul 14, 2022 · 3 comments
Open

Import SSH public keys from 3rd parties (GitHub, GitLab, BitBucket) #11370

loujaybee opened this issue Jul 14, 2022 · 3 comments
Labels
feature: ssh meta: never-stale This issue can never become stale team: IDE

Comments

@loujaybee
Copy link
Member

loujaybee commented Jul 14, 2022

SSH keys can now be uploaded to Gitpod: https://www.gitpod.io/blog/ssh-key-upload

This issue is to investigate supporting ingesting keys already uploaded to 3rd parties that are connected with Gitpod.

Consideration:

  • Removing keys when removed from 3rd party (and making this transparent)

Relates to:

@iQQBot
Copy link
Contributor

iQQBot commented Jul 14, 2022

Removing keys when removed from 3rd party (and making this transparent)

This event notification may not exist here, so if you want to achieve it, you may only be able to rotate training regularly, which is not a good practice, in addition to the import is not automatic, so I think follow the deletion is not necessary

@gtsiolis
Copy link
Contributor

gtsiolis commented Jul 14, 2022

@loujaybee, this grabbed my attention and spent a few minutes on how this could look like.

Posting below an early design, but let me know if you think this will be prioritized soon so I can work on more details and edge cases. 🥯

I think I also agree with @iQQBot on skipping syncing the keys as this could affect user control. Similarly, one can delete the key itself locally and the key would remain in the providers.

Things to consider:

  1. Reuse the same flow to import a key as a user would do for uploading a key.
  2. Defaulting to their primary provider or nudging users to select first a provider.
  3. Allowing users to edit the key or title after selecting an existing key but before saving the key.
  4. Including an empty state when there's no key available from the selected provider.
Early design for SSH Key import from providers
ImportSSHKey

@stale
Copy link

stale bot commented Oct 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: ssh meta: never-stale This issue can never become stale team: IDE
Projects
None yet
Development

No branches or pull requests

3 participants