Skip to content

cpu/memory thresholds should be propagated by supervisor #12075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreafalzetti opened this issue Aug 11, 2022 · 2 comments · Fixed by #12157
Closed

cpu/memory thresholds should be propagated by supervisor #12075

andreafalzetti opened this issue Aug 11, 2022 · 2 comments · Fixed by #12157

Comments

@andreafalzetti
Copy link
Contributor

Is your feature request related to a problem? Please describe

Currently, to display high usage of CPU/Memory we replicated thresholds in gitpod-cli and jb backend plugin. Ideally, supervisor should own the thresholds and propagate them to the clients.

Describe the behaviour you'd like

  • hardcoded cpu/memory thresholds are removed from all components
  • thresholds are retrieved from supervisor like we retrieve the resource status

Places in the code to change:

Describe alternatives you've considered

N/A

Additional context

@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented Aug 12, 2022

@akosyakov do you think thresholds should be returned inside ResourcesStatusResponse or shall we have a separate endpoint?

@akosyakov
Copy link
Member

@andreafalzetti I thought it will be part of

message ResourceStatus {
something like

message ResourceStatus {
    int64 used = 1;
    int64 limit = 2;
    ResourceStatusSeverity severity = 3;
}
enum ResourceStatusSeverity {
    normal = 0;
    warning = 1;
    danger = 2;
}

concrete numbers will be implementation details of supervisor

@andreafalzetti andreafalzetti moved this from Scheduled to In Progress in 🚀 IDE Team Aug 16, 2022
Repository owner moved this from In Progress to Done in 🚀 IDE Team Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants